Unvanquished Development activity

Events from:

Unvanquished
Unvanquished
Saturday, 01 April 2023
@slipher slipher commented on Unvanquished/Unvanquished#2559 · April 1, 2023 02:31

Maybe we want to kill some obsolete emoticons like the hovel and do so without breaking backwards compatibility with maps 😛

Daemon Engine
Daemon Engine
Friday, 31 March 2023
@illwieckz illwieckz pushed to DaemonEngine/Daemon · March 31, 2023 22:23
1 commit to illwieckz/min-max
  • @illwieckz f917fdb
    cl_input: use std::min and std::max
@bmorel bmorel commented on DaemonEngine/Daemon#826 · March 31, 2023 22:13

maybe use the occasion to kill zombi code, too.

@DolceTriade DolceTriade commented on DaemonEngine/Daemon#826 · March 31, 2023 22:13

negative conditions like this are impossible to read. We should remove the ! and change all the || to &&

@DolceTriade DolceTriade commented on DaemonEngine/Daemon#826 · March 31, 2023 22:12

Can we have a benchmark that shows the differences with these changes and without? Any noticeable FPS increases? Any measurable CPU usage changes?

@bmorel bmorel commented on DaemonEngine/Daemon#827 · March 31, 2023 21:50

why not using Math::Clamp?

@illwieckz illwieckz opened DaemonEngine/Daemon#827 · March 31, 2023 21:42
cl_input: use `std::min` and `std::max` #827

Use std::min and std::max.

+1 -11
@illwieckz illwieckz created a branch in DaemonEngine/Daemon · March 31, 2023 21:41
@bmorel bmorel commented on DaemonEngine/Daemon#826 · March 31, 2023 21:24

I wonder if those functions should not be inline to help compiler inlining them (I know they don't necessarily obey, but still)?

@illwieckz illwieckz pushed to DaemonEngine/Daemon · March 31, 2023 21:17
2 commits to illwieckz/trace-iterate-pointers
@illwieckz illwieckz pushed to DaemonEngine/Daemon · March 31, 2023 21:14
1 commit to illwieckz/boxtrace-const/sync
  • @illwieckz 637590d
    cm_trace: make CM_BoxTrace mins and maxs const
@illwieckz illwieckz pushed to DaemonEngine/Daemon · March 31, 2023 21:12
1 commit to illwieckz/lightgrid
  • @illwieckz 32250cc
    tr_bsp: do not load the light grid if precomputed lighting is disabled
@illwieckz illwieckz pushed to DaemonEngine/Daemon · March 31, 2023 21:11
2 commits to illwieckz/trace-iterate-pointers
@illwieckz illwieckz opened DaemonEngine/Daemon#826 · March 31, 2023 21:10
common: some optimizations in tracing code #826

When spamming grenades, some parts of the tracing codes is iterated millions time. For example the CM_TestInLeaf function can count for 10 or 15% o…

+188 -145
@illwieckz illwieckz commented on DaemonEngine/Daemon#822 · March 31, 2023 20:59

Is this for vertex lighting? We have three options: light mapping, uses lightmap for the world, grid light for the models grid lighting, uses gr…

@illwieckz illwieckz commented on Unvanquished/Unvanquished#2559 · March 31, 2023 20:54

It's 2022 man! That's so 2022 !

@bmorel bmorel commented on Unvanquished/Unvanquished#2559 · March 31, 2023 20:54

That's the problem: emoticons in names would make it sooo 2022, and we're already in 2023!

@DolceTriade DolceTriade commented on Unvanquished/Unvanquished#2553 · March 31, 2023 20:53

If players like sudden death I'm ok with it being merged as an optional feature.

@illwieckz illwieckz pushed to Unvanquished/Unvanquished · March 31, 2023 16:59
1 commit to illwieckz/boxtrace-const/sync
  • @illwieckz e421adf
    cg_predict: CM_BoxTrace mins and maxs are const
@illwieckz illwieckz opened Unvanquished/Unvanquished#2562 · March 31, 2023 16:59
cg_predict: CM_BoxTrace mins and maxs are const #2562

There is no need to set a default, CG_Trace handles the nullptr. There is no need to backup mins and maxs, they're not modified. There is no need t…

+3 -22
@illwieckz illwieckz opened DaemonEngine/Daemon#825 · March 31, 2023 16:58
cm_trace: make CM_BoxTrace mins and maxs const #825

Make CM_BoxTrace mins and maxs const. All CM_BoxTrace is doing is to call CM_Trace that already has constness on mins and maxs.

+3 -3
@bmorel bmorel commented on Unvanquished/Unvanquished#2539 · March 31, 2023 15:04

that was just to fix a conflict quickly. I don't like those merge/empty commits neither and will rebase instead.

@bmorel bmorel commented on Unvanquished/Unvanquished#2539 · March 31, 2023 15:03

Yes and no. I guess what would be desired is to go backward as long as your range is superior to your opponent's .

@bmorel bmorel commented on Unvanquished/Unvanquished#2539 · March 31, 2023 15:02

I used this originally, and results felt really bogus. But maybe this was because of other changes, I don't remember for certain (there's more than…

@bmorel bmorel commented on Unvanquished/Unvanquished#2539 · March 31, 2023 15:01

Dunno. Bots already have aim speed dependent on their skill. But I agree they could use a random modifier to decide wether to shoot or not. This co…

@slipher slipher commented on Unvanquished/Unvanquished#2539 · March 31, 2023 14:56

No merge commits please

@slipher slipher commented on Unvanquished/Unvanquished#2539 · March 31, 2023 14:51

Is moving backward with the painsaw desired?

@bmorel bmorel opened an issue in Unvanquished/Unvanquished · March 31, 2023 14:51
bot auto-balance #2561

Few days ago, I had the idea of implementing some automatic bot skill balance. The idea would be that if there's a too big delta between the 2 team…

@slipher slipher commented on Unvanquished/Unvanquished#2539 · March 31, 2023 14:48

I believe you should use BG_GetPlayerWeapon to get the prev weapon

@bmorel bmorel commented on Unvanquished/Unvanquished#2545 · March 31, 2023 14:37

so, shuold I let this dead code around?

@bmorel bmorel commented on Unvanquished/Unvanquished#2535 · March 31, 2023 14:36

If no more questions, 'ill merge this tomorrow

@bmorel bmorel commented on Unvanquished/Unvanquished#2520 · March 31, 2023 14:36

Apparently, entities with "random" or "wait" can have 2 values, 1st being a time, and 2nd the "variance". Now, I can not see such situation in the …

@slipher slipher commented on Unvanquished/Unvanquished#2539 · March 31, 2023 14:34

What's the point of "AI: BotTargetInAttackRange allows to choose weapon" ?

@slipher slipher commented on Unvanquished/Unvanquished#2539 · March 31, 2023 14:33

This seems like unfairly aimbot-like behavior if the painsaw is only fired exactly when it can hit. (I already think bots are too good at painsaw r…

@bmorel bmorel commented on Unvanquished/Unvanquished#2553 · March 31, 2023 14:19

What I would propose is to make aliens regeneration depends on the presence of an OM. It would reduce the endless egg hunt a lot.

@slipher slipher commented on Unvanquished/Unvanquished#2524 · March 31, 2023 14:10

static void nullCleanFunc

@slipher slipher commented on Unvanquished/Unvanquished#2524 · March 31, 2023 13:58

You have to check if the returned command actually matches what you searched for

@slipher slipher commented on Unvanquished/Unvanquished#2524 · March 31, 2023 13:57

Why do we need to check if the string is null? cmdcmp doesn't do that

@slipher slipher commented on Unvanquished/Unvanquished#2524 · March 31, 2023 13:48

You can reduce the size of this array

@slipher slipher commented on Unvanquished/Unvanquished#2524 · March 31, 2023 13:47

This would happen due to a mistake in the RML so it should be a warning rather than an assertion

@slipher slipher commented on Unvanquished/Unvanquished#2545 · March 31, 2023 13:42

Probably in case of version skew, to avoid spam when using a newer gamelogic with the old config file

@slipher slipher commented on Unvanquished/Unvanquished#2559 · March 31, 2023 13:40

Do we want to support emoticons in map and author names? Not really

@slipher slipher commented on Unvanquished/Unvanquished#2560 · March 31, 2023 13:34

What you could do is to keep a high-water mark of the highest entity number seen and only iterate up to there. That's what sgame does to avoid payi…

@slipher slipher commented on Unvanquished/Unvanquished#2533 · March 31, 2023 13:30

Does this happen only when you hack daemon to unlock infinite fps or are there other ways?

@illwieckz illwieckz pushed to Unvanquished/Unvanquished · March 31, 2023 13:18
illwieckz/loop-once is now 39ed455
@illwieckz illwieckz pushed to Unvanquished/Unvanquished · March 31, 2023 13:06
2 commits to illwieckz/loop-once
@illwieckz illwieckz commented on Unvanquished/Unvanquished#2560 · March 31, 2023 13:03

I split the loop into two half-loops (entities are still iterated only once) to remove a test.

@illwieckz illwieckz commented on Unvanquished/Unvanquished#2560 · March 31, 2023 12:43

In fact the entities are iterated a fifth time, but only if cg_drawBBOX.Get() is true, but given this one is a debug cheat, we can keep it outside …

@illwieckz illwieckz opened Unvanquished/Unvanquished#2560 · March 31, 2023 12:38
WIP: loop entities once in `CG_AddPacketEntities()` #2560

By running the game on Orbit profiler after having tweaked the engine to run on 0 frametime and not be polluted by any idling code, and running the…

+23 -26
@slipher slipher commented on Unvanquished/Unvanquished#2533 · March 31, 2023 12:33

What we generally want to do here is just get the same result as the previous frame. All of the code between filter.SetWidth( 350 ); and offsets = …

@bmorel bmorel pushed to Unvanquished/Unvanquished · March 31, 2023 10:10
2 commits to lesser-autojump
@illwieckz illwieckz commented on DaemonEngine/Daemon#817 · March 31, 2023 09:56

or place buildables with non-toggled wallwalk

@illwieckz illwieckz commented on Unvanquished/Unvanquished#2559 · March 31, 2023 09:50

Maybe we can also define some guidelines to write author names without clan, for example. Maps likely survive clans.

@illwieckz illwieckz commented on Unvanquished/Unvanquished#2559 · March 31, 2023 09:49

Since I was the one implementing that map loading screen and that I haven't set the emoticons flag at first, I'm confident my opinion at the time w…

@sweet235 sweet235 commented on Unvanquished/Unvanquished#2553 · March 31, 2023 09:49

This would be solved by having a sudden death The sudden death implementation seems to be quite stable. The main reason it is not merged is this:…

@illwieckz illwieckz opened Unvanquished/Unvanquished#2559 · March 31, 2023 09:47
Do we want to support emoticons in map and author names? #2559

I first thought it was a bug, but maybe we prefer to keep map and author names text only. What's your thought about it?

+2 -2
@slipher slipher commented on Unvanquished/Unvanquished#2557 · March 31, 2023 09:02

So the question I had on IRC was what should happen if you have something like if numClients > 8 thunder in the random rotation, what should happen…

@slipher slipher merged Unvanquished/Unvanquished#2549 · March 31, 2023 08:57
Allow complex logical expressions in map rotation conditions #2549

This will allow more complex conditions like numPlayers >= 6 && lastWin Aliens in a map rotation. Also I added arithmetic operators. There's probab…

+338 -172
3 comments
@slipher slipher pushed to Unvanquished/Unvanquished · March 31, 2023 08:57
2 commits to master
@illwieckz illwieckz commented on DaemonEngine/Daemon#819 · March 31, 2023 08:52

Please review those PR before reviewing this one: #820 #821 #822 #823 #824

@illwieckz illwieckz opened DaemonEngine/Daemon#824 · March 31, 2023 08:44
tr_local: cleanup an useless declaration #824

Extracted from: #819 Cleanup an useless declaration. This would have been useful if a struct or a function declaration used that type before that…

+0 -2
@illwieckz illwieckz opened DaemonEngine/Daemon#823 · March 31, 2023 08:40
tr_init: make r_precomputedLighting a cheat cvar #823

Extracted from: #819 Make r_precomputedLighting a cheat cvar. Disabling this cvar disables all precomputed shadows and then makes everything full…

+1 -1
@illwieckz illwieckz opened DaemonEngine/Daemon#822 · March 31, 2023 08:35
tr_bsp: do not load the grid grid if precomputed lighting is disabled #822

Extracted from: #819 Do not load the light grid if precomputed lighting is disabled.

+55 -43
@illwieckz illwieckz created a branch in DaemonEngine/Daemon · March 31, 2023 08:34
@illwieckz illwieckz pushed to DaemonEngine/Daemon · March 31, 2023 08:33
1 commit to illwieckz/lightmap-size
  • @illwieckz 266165b
    tr_bsp: set internalLightMapSize in the block using it
@illwieckz illwieckz opened DaemonEngine/Daemon#821 · March 31, 2023 08:33
renderer: set internalLightMapSize in the block using it #821

Extracted from: #819 Set internalLightMapSize in the block using it, a global variable is useless.

+13 -12
@illwieckz illwieckz pushed to DaemonEngine/Daemon · March 31, 2023 08:30
2 commits to illwieckz/some-rewrite
  • @illwieckz ca4b75a
    tr_shade,tr_shader: set colorGen and alphaGen only once
  • @illwieckz 5190ce1
    tr_shade,tr_shader: select shader stage render function only once
  • 7 more commits »
@illwieckz illwieckz opened DaemonEngine/Daemon#820 · March 31, 2023 08:25
Illwieckz/lighting cvars #820

Extracted from: #819 The render is now as expected not only when r_precomputedLighting is enabled but also when it is disabled. Disabling lightma…

+31 -26
@illwieckz illwieckz pushed to DaemonEngine/Daemon · March 31, 2023 08:25
1 commit to illwieckz/lighting-cvars
  • @illwieckz fd047e0
    tr_shade: Render_LightMapping() always knows how to render
@illwieckz illwieckz pushed to DaemonEngine/Daemon · March 31, 2023 08:23
2 commits to illwieckz/lighting-cvars
  • @illwieckz 57f019d
    tr_shade: Render_LightMapping() always knows how to render
  • @illwieckz fcad5fb
    tr_bsp: rework precomputed light, light map, deluxe map enablement
@illwieckz illwieckz commented on DaemonEngine/Daemon#819 · March 31, 2023 08:22

I'm splitting the PR.

@illwieckz illwieckz pushed to DaemonEngine/Daemon · March 31, 2023 08:15
2 commits to illwieckz/some-rewrite
  • @illwieckz 7b0e1b2
    tr_shade,tr_shader: set colorGen and alphaGen only once
  • @illwieckz 5128f3a
    tr_shade,tr_shader: select shader stage render function only once
  • 7 more commits »
@illwieckz illwieckz pushed to DaemonEngine/Daemon · March 31, 2023 08:12
2 commits to illwieckz/some-rewrite
  • @illwieckz ffd9079
    tr_shade,tr_shader: set colorGen and alphaGen only once
  • @illwieckz 6fb04d3
    tr_shade,tr_shader: select shader stage render function only once
  • 6 more commits »
@bmorel bmorel opened an issue in Unvanquished/Unvanquished · March 31, 2023 05:22
bots fire when seing nothing #2558

Sometimes, bots fire without an enemy target. When this happen, they fire a single time. I do not know the exact conditions where this happen.

@bmorel bmorel pushed to Unvanquished/Unvanquished · March 31, 2023 03:58
1 commit to lesser-autojump
@bmorel bmorel commented on Unvanquished/Unvanquished#2535 · March 31, 2023 03:52

Also NAVMESHSET_VERSION should be bumped since one of the header structs is changed done

@bmorel bmorel pushed to Unvanquished/Unvanquished · March 31, 2023 03:50
1 commit to lesser-autojump
@slipher slipher commented on Unvanquished/Unvanquished#2535 · March 31, 2023 03:49

Also NAVMESHSET_VERSION should be bumped since one of the header structs is changed

@bmorel bmorel pushed to Unvanquished/Unvanquished · March 31, 2023 01:57
2 commits to trace-API
@bmorel bmorel created a branch in Unvanquished/Unvanquished · March 31, 2023 00:11
Daemon Engine
Daemon Engine
Thursday, 30 March 2023
@illwieckz illwieckz commented on DaemonEngine/Daemon#819 · March 30, 2023 22:52

The two biggest points would be summarized that way: Disabling r_precomputedLighting now works correctly, and it is now a cheat cvar (disables all…