Unvanquished Development activity

Events from:

Unvanquished
Unvanquished
Thursday, 21 January 2021
@illwieckz
illwieckz commented on pull request Unvanquished/updater#81 Jan 21, 2021

If all OS have 7z command line utility available, we may do 7z -tzip -mx=9 a something.zip somefile instead, for better (but still zip) compression. …

@illwieckz
illwieckz commented on pull request Unvanquished/updater#81 Jan 21, 2021

Since we already do Unvanquished Updater.app with one space for macos, maybe we can do it other OS?

@illwieckz
illwieckz commented on pull request Unvanquished/updater#81 Jan 21, 2021

Why not just Unvanquished Updater or UnvanquishedUpdater? (Also, maybe we can use spaces in 2020).

@illwieckz
illwieckz opened a pull request in Unvanquished/updater Jan 21, 2021
@illwieckz
illwieckz opened a pull request in Unvanquished/updater Jan 21, 2021
newscard: wordwrap the title #83

Wordwrap the newscard title, also fix some whitespace Before: After: Since I previously extracted the link from the summary to make sure it's alw…

+14 -12
@illwieckz
illwieckz commented on issue Unvanquished/updater#82 Jan 21, 2021

I just noticed that implementing the single-url download bootstrap (#46, #78) may makes this easier to implement. Of course, until such option is i…

@slipher
slipher commented on issue Unvanquished/updater#82 Jan 21, 2021

The updater already works optimally on disconnected networks. Note that it is impossible to do an updater update if you click the gear button. The …

@illwieckz
illwieckz opened an issue in Unvanquished/updater Jan 21, 2021
Option to not phone home at at startup (add “do not check for updates” as an opt out) #82

When the desktop file did not launched the updater but the game, people not wanting to phone home just had to click the Unvanquished icon and not r…

@slipher
slipher commented on issue Unvanquished/updater#26 Jan 21, 2021

Reopening because I still need to check the case of launching the game after an updater update.

@slipher
slipher reopened an issue in Unvanquished/updater Jan 21, 2021
Unvanquished does not load properly if updater runs in a terminal on Linux #26

Hi, it's probably related to some stdio stuff, but Unvanquished hangs at startup when launched by from the updater if the updater runs in a terminal.

6 comments
@slipher
slipher opened a pull request in Unvanquished/updater Jan 21, 2021
@slipher
slipher closed an issue in Unvanquished/updater Jan 21, 2021
Unvanquished does not load properly if updater runs in a terminal on Linux #26

Hi, it's probably related to some stdio stuff, but Unvanquished hangs at startup when launched by from the updater if the updater runs in a terminal.

6 comments
@slipher
slipher pushed to Unvanquished/updater Jan 21, 2021
2 commits to master
@slipher
slipher merged a pull request in Unvanquished/updater Jan 21, 2021
Small bug fixes and cleanups #79

It fixes the Linux terminal bug.

+46 -26
1 comment
@slipher
slipher commented on pull request Unvanquished/updater#79 Jan 21, 2021

I think it's good to keep track of what names were used in the past, so that one is not accidentally reused.

Unvanquished
Unvanquished
Wednesday, 20 January 2021
@illwieckz
illwieckz commented on pull request Unvanquished/updater#76 Jan 20, 2021

Well, if PrefersNonDefaultGPU does not prefer non-default GPU, the name itself would be a design issue.

@slipher
slipher commented on pull request Unvanquished/updater#76 Jan 20, 2021

Are you just speculating based on the name or did you find some inf about what PrefersNonDefaultGPU does in real implementations? I found some merg…

@illwieckz
illwieckz commented on pull request Unvanquished/updater#80 Jan 20, 2021

It is now possible to start the updater as non-admin. That's very good!

@slipher
slipher opened a pull request in Unvanquished/updater Jan 20, 2021
Use updater as launcher on Windows #80

It is now possible to start the updater as non-admin. UAC elevation with a relaunched process is requested at the moment when an updater update is …

+252 -61
@illwieckz
illwieckz commented on pull request Unvanquished/updater#76 Jan 20, 2021

About PrefersNonDefaultGPU=true in desktop file, you may want to read this: https://gitlab.com/xonotic/xonotic/-/merge_requests/66#note_343857927 W…

@slipher
slipher commented on pull request Unvanquished/updater#79 Jan 20, 2021

Actually, I should say it mostly fixes the terminal bug. In the case of an updater update, the game process will eventually spawn off an updater pr…

@illwieckz
illwieckz commented on pull request Unvanquished/updater#78 Jan 20, 2021

The game URL actually doesn't depend on the version number currently. Ah, yes… 😕

@slipher
slipher opened a pull request in Unvanquished/updater Jan 20, 2021
Small bug fixes and cleanups #79

It fixes the Linux terminal bug.

+46 -26
@slipher
slipher commented on pull request Unvanquished/updater#78 Jan 20, 2021

It doesn't introduce an issue for the updater URL, since updater update can only be initiated when the versions request has succeeded. It does crea…

@divVerent have this ever worked?
Because it attempts to load e.g. path/model.md3_.skin.
Also Q3A doesn't support numbered skins, but named instead, e.g. head_blue.skin, head_red.skin for head.md3, head_1.md3, head_2.md3

@illwieckz
illwieckz commented on pull request Unvanquished/updater#78 Jan 20, 2021

We may postpone the news part, right? For the updater and game URLs I don't believe this PR adds more issue than there was before since those URLs …

@slipher
slipher commented on pull request Unvanquished/updater#78 Jan 20, 2021

The overall concept is good. Besides permitting flexibility in the server configuration, this will be helpful when testing the updater. However, I …

Unvanquished
Unvanquished
Tuesday, 19 January 2021
@illwieckz
illwieckz commented on issue Unvanquished/updater#46 Jan 19, 2021

After having implemented it in #78, this is the current format: { "news": { "version": "rolling", "mirrors": [ "https://unvanquished.net/api" ], "p…

@illwieckz
illwieckz opened a pull request in Unvanquished/updater Jan 19, 2021
Fetch all URLs from a single URL, fix #46 #78

Only one URL is hardcoded, which is a json file telling everything else. The format is meant to be able to update the paths after a release, and im…

+126 -51
@slipher
slipher commented on issue Unvanquished/updater#26 Jan 19, 2021

The situation that arises is actually identical to that when you start daemon from a Windows command prompt: stdout is connected to the terminal, b…

@illwieckz
illwieckz commented on issue Unvanquished/updater#74 Jan 19, 2021

Note that UPX-compressed binaries may have issue about finding their “running directory” (or their own executable file path). I attempted to compre…

@slipher
slipher commented on issue Unvanquished/updater#49 Jan 19, 2021

Download link is now pointing to the .exe, thanks illwieckz. I wonder if this issue could occur on Linux too. There are many file browsers, so ther…

@slipher
slipher closed an issue in Unvanquished/updater Jan 19, 2021
Self-update does not work when updater is launched from the zip file (windows allows to browse zip files like directories) #49

The updater's self-update functionality (replacing its own binary) does not work when it is launched from a zip file, as the binary path is some te…

7 comments
@slipher
slipher pushed to Unvanquished/updater Jan 19, 2021
1 commit to master
  • @slipher c1ca1d9
    Windows Docker: use own Qt build instead of MXE
@slipher
slipher merged a pull request in Unvanquished/updater Jan 19, 2021
Windows Docker: use own Qt build instead of MXE #77

I'm doing this because using MXE leads to a binary size regression. We can't add options like -optimize-size when using MXE. updater2.exe sizes: v0…

+27 -37
@slipher
slipher commented on issue Unvanquished/updater#26 Jan 19, 2021

Haha, I did not notice the bug before because I used the original 0.51.1 daemon which crashes immediately on the distro I'm testing on.

@illwieckz
illwieckz commented on issue Unvanquished/updater#26 Jan 19, 2021

Another way to workaround the bug is to run the updater this way: </dev/null ./updater2

@illwieckz
illwieckz reopened an issue in Unvanquished/updater Jan 19, 2021
Unvanquished does not load properly if updater run in a terminal #26

Hi, it's probably related to some stdio stuff, but Unvanquished hangs at startup when launched by from the updater if the updater runs in a terminal.

3 comments
@illwieckz
illwieckz commented on issue Unvanquished/updater#26 Jan 19, 2021

Latest branch of QML updater reproduces the bug.

Unvanquished
Unvanquished
Sunday, 17 January 2021
@slipher
slipher opened a pull request in Unvanquished/updater Jan 17, 2021
Windows Docker: use own Qt build instead of MXE #77

I'm doing this because using MXE leads to a binary size regression. We can't add options like -optimize-size when using MXE. updater2.exe sizes: v0…

+27 -37
@slipher
slipher pushed to Unvanquished/updater Jan 17, 2021
2 commits to master
@slipher
slipher closed an issue in Unvanquished/updater Jan 17, 2021
updater does not actually install unv:// protocol association on Linux #34

It installs desktop file and icon, but not association. To install association add the line x-scheme-handler/unv=unvanquished.desktop to the 'Defa…

5 comments
@slipher
slipher merged a pull request in Unvanquished/updater Jan 17, 2021
Use updater as launcher on Mac and Linux #76

Also fix the unv:// protocol handler on Linux (it's not implemented on Mac). Still need some adjustments with admin elevations before switching to …

+124 -27
@slipher
slipher commented on issue Unvanquished/updater#37 Jan 17, 2021

The flag -schannel must be passed to the configure script for Qt to support HTTPS. The old Docker build did not have this option, so probably the r…

Unvanquished
Unvanquished
Saturday, 16 January 2021
@slipher
slipher commented on pull request Unvanquished/updater#63 Jan 16, 2021

OK, naming it updater in the install directory makes sense to me. I just updated #76 to use this name, as the name in the install directory is inde…

@slipher
slipher commented on issue Unvanquished/updater#49 Jan 16, 2021

@illwieckz I added the bare Windows executable into the v0.0.5 release on Github. Can you change the unvanquished.net/download link to point to tha…

@slipher
slipher commented on issue Unvanquished/updater#74 Jan 16, 2021

I guess Linux is just doomed to be inconvenient then. Mac is all right, because it has a default behavior of automatically unzipping the zip to a n…

@illwieckz
illwieckz commented on issue Unvanquished/updater#74 Jan 16, 2021

Executable bit is meant to be stored on the storage layer, so distributing bare executable on Linux requires the user to flip the executable bit hi…

@slipher
slipher commented on issue Unvanquished/updater#74 Jan 16, 2021

Something I should have asked - does distributing a bare executable for Linux even work? I don't know whether there's any way to get it to download…

Unvanquished
Unvanquished
Friday, 15 January 2021
@Kangz
Kangz pushed to Unvanquished/Unvanquished Jan 15, 2021
1 commit to wasm/sync
  • @Kangz eff5a32
    Skip shmRegion creation for now in WASM
@Kangz
Kangz pushed to DaemonEngine/Daemon Jan 15, 2021
2 commits to wasm/sync
@Kangz
Kangz pushed to DaemonEngine/Daemon Jan 15, 2021
1 commit to wasm/sync
  • @Kangz 7387e7b
    Violently make sgame compile with WASM
@Kangz
Kangz created a branch in DaemonEngine/Daemon Jan 15, 2021

Updated Jan 18

@Calinou
Calinou commented on issue Unvanquished/updater#74 Jan 15, 2021

UPX has a bad track record with false positives on antivirus programs. I would recommed avoiding it in 2021. Also, if your distribution is already …

@slipher
slipher commented on issue Unvanquished/updater#74 Jan 15, 2021

For the next updater release, I'm thinking we should distribute UPX binaries for Windows and Linux on the download page. As a backup in case those …

@illwieckz
illwieckz commented on issue Unvanquished/updater#74 Jan 15, 2021

One good thing about the zip is that we can give any name to the zip, like UnvanquishedUpdater_0.6.0+linux-amd64.zip or UnvanquishedUpdater_0.6.0+b…

@illwieckz
illwieckz commented on pull request Unvanquished/updater#63 Jan 15, 2021

The idea of updater name is for when it is stored in user directory as part of the installation. For the distributed file, I would recommend callin…

@slipher
slipher commented on issue Unvanquished/updater#25 Jan 15, 2021

The launcher functionality is now being brought to a good state.

@slipher
slipher closed an issue in Unvanquished/updater Jan 15, 2021
Make installer only, dropping launcher/self-updater concepts? #25

The idea would be to drop the updater update implementation since it is too half-baked currently (for example the exe may be a temp file if the upd…

7 comments
@slipher
slipher commented on pull request Unvanquished/updater#63 Jan 15, 2021

Renaming at some point seems like a good idea, but we should take the opportunity to pick something more descriptive than updater. Perhaps unvanqui…

@slipher
slipher opened a pull request in Unvanquished/updater Jan 15, 2021
Use updater as launcher on Mac and Linux #76

Also fix the unv:// protocol handler on Linux (it's not implemented on Mac). Still need some adjustments with admin elevations before switching to …

+124 -27
@slipher
slipher closed an issue in Unvanquished/updater Jan 15, 2021
add a checkbox to start the game right after being downloaded #48

Right under the download bar in main ui we may add a checkbox to tell the updater to automatically run the game once download finishes. In options,…

2 comments
@slipher
slipher pushed to Unvanquished/updater Jan 15, 2021
2 commits to master
@slipher
slipher closed an issue in Unvanquished/updater Jan 15, 2021
prevent people "accidentally" run updater as root #65

I've seen on IRC that some people run the updater as root, and then chmod foo:bar $GAMEDIR. Running stuff as root can be handful, but also reserved…

6 comments
@slipher
slipher merged a pull request in Unvanquished/updater Jan 15, 2021
Bugfixes #75
+74 -36
1 comment
@slipher
slipher commented on pull request Unvanquished/updater#75 Jan 15, 2021
@DolceTriade
DolceTriade commented on pull request Unvanquished/updater#75 Jan 15, 2021

But I don't feel strongly enough to block this change on that.

@DolceTriade
DolceTriade commented on pull request Unvanquished/updater#75 Jan 15, 2021

I think we can trivially make this better by assuming that if %command% isn't there, then the arguments that are saved should be appendeded to %com…

Unvanquished
Unvanquished
Thursday, 14 January 2021
@slipher
slipher commented on pull request Unvanquished/updater#75 Jan 14, 2021

Well, I don't want to spend a lot of time on this now. I can remove the validator if you think that's better.

@DolceTriade
DolceTriade commented on pull request Unvanquished/updater#75 Jan 14, 2021
@DolceTriade
DolceTriade commented on pull request Unvanquished/updater#75 Jan 14, 2021

This isn't super good UX. Maybe do the validation in onEditingFinished?

Changes making easier to collaborate together on a git-based workflow is welcome.

@slipher
slipher opened a pull request in Unvanquished/updater Jan 14, 2021
Bugfixes #75
+75 -34
@FreeSlave
FreeSlave commented on issue Unvanquished/updater#56 Jan 14, 2021

Hello, I'm fine with that change.

Unvanquished
Unvanquished
Wednesday, 13 January 2021
@slipher
slipher commented on issue Unvanquished/updater#74 Jan 13, 2021

These scans don't look too bad - upx/upx#437

@DolceTriade
DolceTriade commented on issue Unvanquished/updater#74 Jan 13, 2021

I had looked into this earlier. The rationale for not picking this was that it can register as a virus sometimes and 1 MiB doesn't really warrant t…

@slipher
slipher commented on pull request Unvanquished/Unvanquished#1281 Jan 13, 2021

"new anim" is not a very informative name IMO. How about "inverse togglebit"? Also this would be better as an inline function instead of a macro.

@slipher
slipher commented on pull request Unvanquished/Unvanquished#1270 Jan 13, 2021

Doesn't this make granger->dretch "devolving"? We don't want that.

@illwieckz
illwieckz opened an issue in Unvanquished/updater Jan 13, 2021
Self-compressed binaries? #74

@slipher proposed we may ship bare binaries instead of shipping them within .zip files. What if we use a self-compressed format like UPX? I made so…

@illwieckz
illwieckz closed an issue in Unvanquished/updater Jan 13, 2021
Linux docker build: AX_CXX_COMPILE_STDCXX(11, noext, mandatory) #73

I tried the docker Linux build and got this: ./configure: line 13883: syntax error near unexpected token `11,' ./configure: line 13883: `AX_CXX_COM…

1 comment
@illwieckz
illwieckz commented on issue Unvanquished/updater#73 Jan 13, 2021

Hum, reset submodule reference and submodule files state and now it works.

@Kangz
Kangz pushed to Unvanquished/Unvanquished Jan 13, 2021
2 commits to 0.52.0/sync
  • @Kangz d433aec
    Merge pull request #1283 from Kangz/0.52.0-fix
  • @Kangz 949ad07
    Fix compilation error with mismatch type in Math::Clamp
@illwieckz
illwieckz opened an issue in Unvanquished/updater Jan 13, 2021
Linux docker build: AX_CXX_COMPILE_STDCXX(11, noext, mandatory) #73

I tried the docker Linux build and got this: ./configure: line 13883: syntax error near unexpected token `11,' ./configure: line 13883: `AX_CXX_COM…

@illwieckz
illwieckz commented on issue Unvanquished/updater#49 Jan 13, 2021

If we distribute the updater outside of a zip, why not using UPX. Here are statistics from v0.0.5 updater: $ du -sh updater2-upx updater2 UnvUpdate…

@slipher
slipher pushed to Unvanquished/updater Jan 13, 2021
2 commits to master
@slipher
slipher merged a pull request in Unvanquished/updater Jan 13, 2021
Update Linux Qt + other Docker enhancements #72

Now all 3 OSes are building on Qt 5.14.

+81 -9
3 comments

When working on a map with multiple people simultaneously, there's a need to be able to work on different parts of the map in tandem without interference. In other map formats, this would be done with an instancing system. But failing that, I worked out somewhat of a clean workflow between Trenchbroom and NetRadiant users. The NetRadiant user works on a 'master' version of a file, and multiple Trenchbroom users can put their work in different "Layers", which are easily transferred to the master file with a single pull/paste/commit. Upon being transferred across, any number of changes can be made in TB and then transferred across, however NetRadiant users have to be very careful not to touch a Trenchbroom layer, or it could easily result in duplicate brushes or entities upon cut/pasting a layer. NetRadiant supporting this system would allow it to be more compatible with modern workflows, and to make collaboration between netradiant/tb effortless.

Okay, so, the actual request is:

  • Support for Trenchbroom's Layering system, including parsing locks / names.
  • Select all inside a layer. (For transfer purposes)
  • Right-click transfer selected brushes to the layer.

And some extra goodies that aren't required for the workflow to function:

  • Isolate/hide any number of individual layers.
  • Lock/unlock certain layers so they cannot be manipulated.
@DolceTriade
DolceTriade commented on pull request Unvanquished/updater#72 Jan 13, 2021

Do the fact we would build Qt ourselves would allow us to build a more lightweight Qt (by not building useless stuff) because the final binary si…

Unvanquished
Unvanquished
Tuesday, 12 January 2021
@necessarily-equal
necessarily-equal commented on pull request Unvanquished/Unvanquished#1283 Jan 12, 2021

Looks good to me, though maybe with b->size = Math::Clamp( cgs.bc.hudSize / static_cast<float>( sqrt( b->dist ) ), … so that the division is made w…

@Kangz
Kangz pushed to Unvanquished/Unvanquished Jan 12, 2021
1 commit to 0.52.0/sync
@Kangz
Kangz pushed to DaemonEngine/Daemon Jan 12, 2021
2 commits to 0.52.0/sync
@Kangz
Kangz closed a pull request in DaemonEngine/Daemon Jan 12, 2021
+36 -184
@Kangz
Kangz opened a pull request in DaemonEngine/Daemon Jan 12, 2021
+36 -184