sweet235 commented Jul 27, 2024

Someone said bisecting leads to 117e11b.

VReaperV commented Jul 27, 2024

Added some comments.

VReaperV commented Jul 27, 2024

We'd need millions of surfaces to exceed this, so it's fine.

github-advanced-security commented Jul 27, 2024

Multiplication result converted to larger type Multiplication result may overflow 'unsigned int' before it is converted to 'unsigned long'. Show mo…

VReaperV commented Jul 27, 2024

I've added a comment about MaterialPack here.

VReaperV commented Jul 27, 2024

Will add in #1137.

VReaperV commented Jul 27, 2024

Thx, biggest part of the changes done now finally.

illwieckz commented Jul 27, 2024

I would appreciate this comment in code.

VReaperV commented Jul 27, 2024

Rebased on material branch now since I'm just waiting for someone to approve the changes in #1105 so I can merge them.

sweet235 commented Jul 26, 2024

To me it would make more sense to trace a constant distance below the player's feet. That would miss any upward slopes. Better trace from the pla…

VReaperV commented Jul 26, 2024

If it's ready to merge I can make a PR enabling bindless and detecting drivers for selective disablement after this is merged. Sure, that'd work …

VReaperV commented Jul 26, 2024

gpuinfo.org is the one to check for hardware capabilities/extension availability yes. I have some Intel HD (from UHD generation) but I doubt it su…

illwieckz commented Jul 26, 2024

According to the Intel Xe on Windows 10 supports bindless texture: https://opengl.gpuinfo.org/displayreport.php?id=13101 I don't own any Intel Xe. I…

illwieckz commented Jul 26, 2024

If it's ready to merge I can make a PR enabling bindless and detecting drivers for selective disablement after this is merged. Is there something r…

illwieckz commented Jul 26, 2024

In Khronos wiki: https://www.khronos.org/opengl/wiki/Bindless_Texture I read this: It is implemented across much of the OpenGL 4.x hardware spectr…

slipher commented Jul 26, 2024

Why are there ghost eggs at all? Could be because the buildable has a different bbox size. LGTM

VReaperV commented Jul 26, 2024

Nvidia works fine with it on Windows, I can maybe test it on an Intel iGPU later as well. That intel iGPU apparently doesn't support bindless tex…

VReaperV commented Jul 26, 2024

Here is an example of exhaustive search reporting the buggy driver version and disabling the extension when it's detected: I've now added this pa…

cu-kai commented Jul 26, 2024

Please add padding after the opening / before the closing parenthesis to match the style.

VReaperV commented Jul 24, 2024

We already do such kind of disablement for other buggy drivers / hardware, you can look for foundIntel and foundNvidia340. I'll look at those, th…

illwieckz commented Jul 24, 2024

AMD OGLP on Linux produces a black screen with bindless textures. The problem is that both AMD OGLP on Linux and AMD Adrenalin on Windows has GL_VE…

illwieckz commented Jul 24, 2024

We already do such kind of disablement for other buggy drivers / hardware, you can look for foundIntel and foundNvidia340. Running the game with bi…

VReaperV commented Jul 24, 2024

If that's working properly on your end with buggy/non-buggy versions I'll add it to the pr later, unless you wanna add that yourself.

illwieckz commented Jul 24, 2024

I edited the patch to make it more performant.

VReaperV commented Jul 24, 2024

I was thinking of just a warning print, but I guess it's better to disable it as well on those versions since we know it doesn't work properly there.

illwieckz commented Jul 24, 2024

Here is an example of exhaustive search reporting the buggy driver version and disabling the extension when it's detected: diff --git a/src/engine/…

VReaperV commented Jul 24, 2024

Good, once that is fixed I'll enable the extension but default. Yeah, a blacklist for driver versions and print a warning about a driver update req…

VReaperV commented Jul 24, 2024

I suppose this is somewhat the case now since I did have to put some things into separate shader code files.

illwieckz commented Jul 24, 2024

Copied there: Unvanquished/Unvanquished#3073

illwieckz commented Jul 24, 2024

Ah lol, well, the issue is real. :D

illwieckz commented Jul 24, 2024

The remaining Mesa radeonsi error has a pending fix: https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/30338 I seen the proposed piglit t…

slipher commented Jul 24, 2024

We don't use this repository any more.

illwieckz commented Jul 23, 2024

r_useMaterialSystem also renamed to r_materialSystem, in line with other r_* cvars. Great!

VReaperV commented Jul 23, 2024

r_useMaterialSystem also renamed to r_materialSystem, in line with other r_* cvars.

VReaperV commented Jul 23, 2024

Good point, fixed.

VReaperV commented Jul 23, 2024

Fixed.

VReaperV commented Jul 23, 2024

Suggested minor change (make the r_arb_bindless_texture cvar latched): diff --git a/src/engine/sys/sdl_glimp.cpp b/src/engine/sys/sdl_glimp.cpp in…

VReaperV commented Jul 23, 2024

Done.

VReaperV commented Jul 23, 2024

Removed all the && false and commented out stuff related to vertex/bone animation.

VReaperV commented Jul 23, 2024

Fixed.

VReaperV commented Jul 23, 2024

Ah, yep, done.

VReaperV commented Jul 23, 2024

Fixed.

VReaperV commented Jul 23, 2024

Replaced with a different comment that has an actual explanation.

illwieckz commented Jul 23, 2024

Suggested minor change (make the r_arb_bindless_texture cvar latched): diff --git a/src/engine/sys/sdl_glimp.cpp b/src/engine/sys/sdl_glimp.cpp ind…

illwieckz commented Jul 23, 2024

The bug identified on Mesa now has been bisteced: https://gitlab.freedesktop.org/mesa/mesa/-/issues/11535 And a fix has been proposed by Timothy …

illwieckz commented Jul 23, 2024

So I rebased, and race conditions should now be avoided. Here is an example of current.json: https://cdn.unvanquished.net/current.json This new fil…

Grise3 commented Jul 22, 2024

Thanks!

sweet235 commented Jul 22, 2024

Rebased to fix conflict with master. Reduced the allowed range of values to the interval from 0.6 to 2.0. This prevents problems on all known maps.

VReaperV commented Jul 21, 2024

Well I'm imagining that it could be different because you have two surfaces writing their depth at once, rather that one at a time. Writes to the…

slipher commented Jul 21, 2024

Well I'm imagining that it could be different because you have two surfaces writing their depth at once, rather that one at a time. I don't actuall…

VReaperV commented Jul 20, 2024

But the depth pass is also a material right? So how does it work during that part? Yes. Whichever fragment is closer will overwrite depth, it's n…

slipher commented Jul 20, 2024

In general, they can't since depth buffer guarantees that only one of the fragments will end up being processed. But the depth pass is also a mat…

slipher commented Jul 20, 2024

Oops I mean -1, 0. The 0 is fogNum

VReaperV commented Jul 20, 2024

It's also used to bind the correct shader program.

VReaperV commented Jul 20, 2024

Vertex/bone animation not supported currently and since this only draws BSP surfaces currently it's also not needed right now. I'll probably remove…

VReaperV commented Jul 20, 2024

It's just an abstraction to match a range of materials with the 3 different calls to RB_RenderDrawSurfaces() with 3 different shaderSort_t ranges in …

VReaperV commented Jul 20, 2024

Normally sky is drawn only when sky brushes are processed in RB_RenderDrawSurfaces(), which are only added in R_AddWorldSurfaces(). Since the latte…

VReaperV commented Jul 20, 2024

Isn't 0 used for world lightmap? Skybox doesn't use any lightmaps at all, so -1, which I believe means no lightmap, is what makes sense there to me.

VReaperV commented Jul 20, 2024

So the level of parallelism here is that one "material" is rendered at a time, but all surfaces using the material can be drawn simultaneously. Is…

slipher commented Jul 20, 2024

IIUC all these bools are just scratch variables used during the world command buffer generation, and not part of the real material definition? This…

slipher commented Jul 20, 2024

Please remove commented code blocks