Thomas Debesse (c89c6f64) at 13 Oct 02:53

Merge branch 'packonce' into 'master'

... and 4 more commits

Adds -nobouncestore option to not store lightmaps on every bounce.

q3map2 usually store lightmaps on every bounce, allowing user to interrupt compilation and get working files, but storing lightmaps requires them to be allocated and the allocation process (AKA atlasing or lightmap searching) is single-threaded and can be very slow with high resolution lightmaps, so user can use -nobouncestore to only store then allocate once, at the very end of compilation. This can save a lot of time on high resolution lightmaps. I noticed a 20% compilation time saving on some use cases.

Renames the -fastallocate to -fastlightmapsearch to be explicit (old name is kept for compatibility), the -fastallocate was added recently (see !22) and not yet widely used outside of Unvanquished which I can update so there is no real issue to rename it.

Renames -mi and -mv to explicit -maxsurfaceindexes and -maxsurfacevertices (old names kept for compatibility).

Introduces -maxlightmapvertices that was missing from command line options (was only tweakable in game_*.c files.

Introduces -fastmeta that is equivalent to -maxlightmapverts 64 -maxsurfaceverts 999 -maxsurfaceindexes 6000, i.e. Quake 3 defaults values which are known to be fast. This can be useful to speed-up non-final builds.

Thomas Debesse (7278c27f) at 13 Oct 00:57

Merge branch 'deprecate-makefile' into 'master'

... and 3 more commits

requires make to be called this way:

make I_KNOW_MAKEFILE_IS_DEPRECATED=1

Must not be merged before xonotic!45 is merged.

great

Looks fine, let's get it in this way. I_KNOW_MAKEFILE_IS_DEPRECATED=1 is long enough to find it pretty well when we want to remove it later.

Adds -nobouncestore option to not store lightmaps on every bounce.

q3map2 usually store lightmaps on every bounce, allowing user to interrupt compilation and get working files, but storing lightmaps requires them to be allocated and the allocation process (AKA atlasing or lightmap searching) is single-threaded and can be very slow with high resolution lightmaps, so user can use -nobouncestore to only store then allocate once, at the very end of compilation. This can save a lot of time on high resolution lightmaps. I noticed a 20% compilation time saving on some use cases.

Renames the -fastallocate to -fastlightmapsearch to be explicit (old name is kept for compatibility), the -fastallocate was added recently (see !22) and not yet widely used outside of Unvanquished which I can update so there is no real issue to rename it.

Renames -mi and -mv to explicit -maxsurfaceindexes and -maxsurfacevertices (old names kept for compatibility).

Introduces -maxlightmapvertices that was missing from command line options (was only tweakable in game_*.c files.

Introduces -fastmeta that is equivalent to -maxlightmapverts 64 -maxsurfaceverts 999 -maxsurfaceindexes 6000, i.e. Quake 3 defaults values which are known to be fast. This can be useful to speed-up non-final builds.

Quote by @Garux from some discord channel:

@illwieckz Houston, we've had a problem here this makes prefs dlg to prompt to restart on OK after game been choosen via small global settings dialog e2f605b1

I then said:

I guess we would be able to hack a value in config file that would tell to not display this menu on next start, this value would be reset on startup

So after switching game from within NetRadiant (or other action that just requires a restart like layout switch), NetRadiant does not display the game prompt right after having restarted, to avoid to ask for game twice, and to not bother user with a preference windows that is only expected to be displayed on fresh start, not on restart.

Thomas Debesse (40976179) at 12 Oct 21:38

Merge branch 'restart' into 'master'

... and 4 more commits

@Mario This is probably the only MR I did not asked “what is the status on this?” about it like I did with others because I don't know what this MR is about.

@illwieckz What are your thoughts on this?

@Garux elaborated more on his issue:

me meant following: -choose game via small global settings dialog, ok -goto preferences, change nothing, ok -get prompt to restart, because game was changed, it says

New commit is expected to fix that too, so two issues related to Global Preferences at Startup and Radiant restarting would be fixed by this MR.

Quote by @Garux from some discord channel:

@illwieckz Houston, we've had a problem here this makes prefs dlg to prompt to restart on OK after game been choosen via small global settings dialog e2f605b1

I then said:

I guess we would be able to hack a value in config file that would tell to not display this menu on next start, this value would be reset on startup

So after switching game from within NetRadiant (or other action that just requires a restart like layout switch), NetRadiant does not display the game prompt right after having restarted, to avoid to ask for game twice, and to not bother user with a preference windows that is only expected to be displayed on fresh start, not on restart.