slipher commented Apr 1, 2023

Maybe we want to kill some obsolete emoticons like the hovel and do so without breaking backwards compatibility with maps 😛

illwieckz commented Mar 31, 2023

Good idea!

bmorel commented Mar 31, 2023

maybe use the occasion to kill zombi code, too.

DolceTriade commented Mar 31, 2023

negative conditions like this are impossible to read. We should remove the ! and change all the || to &&

DolceTriade commented Mar 31, 2023

Can we have a benchmark that shows the differences with these changes and without? Any noticeable FPS increases? Any measurable CPU usage changes?

DolceTriade commented Mar 31, 2023

lgtm

bmorel commented Mar 31, 2023

why not using Math::Clamp?

bmorel commented Mar 31, 2023

I wonder if those functions should not be inline to help compiler inlining them (I know they don't necessarily obey, but still)?

illwieckz commented Mar 31, 2023

Is this for vertex lighting? We have three options: light mapping, uses lightmap for the world, grid light for the models grid lighting, uses gr…

illwieckz commented Mar 31, 2023

It's 2022 man! That's so 2022 !

bmorel commented Mar 31, 2023

That's the problem: emoticons in names would make it sooo 2022, and we're already in 2023!

DolceTriade commented Mar 31, 2023

If players like sudden death I'm ok with it being merged as an optional feature.

DolceTriade commented Mar 31, 2023

Why not?

illwieckz commented Mar 31, 2023

The VectorCopy was a workaround: 8e34694#diff-2c4a600fa1e83c39b3c6e54abab63fa569488246d0ba1c1bd71ed16bf8650099R253-R257 The tests for copying a d…

bmorel commented Mar 31, 2023

that was just to fix a conflict quickly. I don't like those merge/empty commits neither and will rebase instead.

bmorel commented Mar 31, 2023

Yes and no. I guess what would be desired is to go backward as long as your range is superior to your opponent's .

bmorel commented Mar 31, 2023

I used this originally, and results felt really bogus. But maybe this was because of other changes, I don't remember for certain (there's more than…

bmorel commented Mar 31, 2023

Dunno. Bots already have aim speed dependent on their skill. But I agree they could use a random modifier to decide wether to shoot or not. This co…

slipher commented Mar 31, 2023

No merge commits please

slipher commented Mar 31, 2023

Is moving backward with the painsaw desired?

slipher commented Mar 31, 2023

I believe you should use BG_GetPlayerWeapon to get the prev weapon

bmorel commented Mar 31, 2023

so, shuold I let this dead code around?

bmorel commented Mar 31, 2023

If no more questions, 'ill merge this tomorrow

bmorel commented Mar 31, 2023

Apparently, entities with "random" or "wait" can have 2 values, 1st being a time, and 2nd the "variance". Now, I can not see such situation in the …

slipher commented Mar 31, 2023

What's the point of "AI: BotTargetInAttackRange allows to choose weapon" ?

slipher commented Mar 31, 2023

This seems like unfairly aimbot-like behavior if the painsaw is only fired exactly when it can hit. (I already think bots are too good at painsaw r…

bmorel commented Mar 31, 2023

What I would propose is to make aliens regeneration depends on the presence of an OM. It would reduce the endless egg hunt a lot.

slipher commented Mar 31, 2023

static void nullCleanFunc

slipher commented Mar 31, 2023

You have to check if the returned command actually matches what you searched for

slipher commented Mar 31, 2023

Why do we need to check if the string is null? cmdcmp doesn't do that

slipher commented Mar 31, 2023

You can reduce the size of this array

slipher commented Mar 31, 2023

This would happen due to a mistake in the RML so it should be a warning rather than an assertion

slipher commented Mar 31, 2023

Probably in case of version skew, to avoid spam when using a newer gamelogic with the old config file

slipher commented Mar 31, 2023

Do we want to support emoticons in map and author names? Not really

slipher commented Mar 31, 2023

What you could do is to keep a high-water mark of the highest entity number seen and only iterate up to there. That's what sgame does to avoid payi…

slipher commented Mar 31, 2023

Does this happen only when you hack daemon to unlock infinite fps or are there other ways?

sweet235 commented Mar 31, 2023

lgtm

illwieckz commented Mar 31, 2023

I split the loop into two half-loops (entities are still iterated only once) to remove a test.

illwieckz commented Mar 31, 2023

In fact the entities are iterated a fifth time, but only if cg_drawBBOX.Get() is true, but given this one is a debug cheat, we can keep it outside …

slipher commented Mar 31, 2023

What we generally want to do here is just get the same result as the previous frame. All of the code between filter.SetWidth( 350 ); and offsets = …

illwieckz commented Mar 31, 2023

or place buildables with non-toggled wallwalk

illwieckz commented Mar 31, 2023

Maybe we can also define some guidelines to write author names without clan, for example. Maps likely survive clans.

illwieckz commented Mar 31, 2023

Since I was the one implementing that map loading screen and that I haven't set the emoticons flag at first, I'm confident my opinion at the time w…

sweet235 commented Mar 31, 2023

This would be solved by having a sudden death The sudden death implementation seems to be quite stable. The main reason it is not merged is this:…

slipher commented Mar 31, 2023

So the question I had on IRC was what should happen if you have something like if numClients > 8 thunder in the random rotation, what should happen…

illwieckz commented Mar 31, 2023

Please review those PR before reviewing this one: #820 #821 #822 #823 #824

slipher commented Mar 31, 2023

Done

illwieckz commented Mar 31, 2023

I'm splitting the PR.

bmorel commented Mar 31, 2023

bump.

bmorel commented Mar 31, 2023

bump.

bmorel commented Mar 31, 2023

Also NAVMESHSET_VERSION should be bumped since one of the header structs is changed done

slipher commented Mar 31, 2023

Also NAVMESHSET_VERSION should be bumped since one of the header structs is changed

illwieckz commented Mar 30, 2023

The two biggest points would be summarized that way: Disabling r_precomputedLighting now works correctly, and it is now a cheat cvar (disables all…