Unvanquished Development activity

Events from:

Daemon Engine
Daemon Engine
Tuesday, 05 December 2023
@illwieckz illwieckz commented on DaemonEngine/Daemon#982 · December 5, 2023 05:07

Note that DaemonCompiler.c and DaemonCompiler.cpp are the exact same file, CMake is annoying because it requires the file extension, I'll look for …

@illwieckz illwieckz pushed to DaemonEngine/Daemon · December 5, 2023 05:03
1 commit to illwieckz/compiler-string/sync
@illwieckz illwieckz commented on DaemonEngine/Daemon#982 · December 5, 2023 05:02

I pushed a different implementation, similar to the one I did to detect architectures (i.e. relying on preprocesor to execute some #ifdef, etc.).

@illwieckz illwieckz pushed to DaemonEngine/Daemon · December 5, 2023 05:01
2 commits to illwieckz/compiler-string/sync
Unvanquished
Unvanquished
Monday, 04 December 2023
@illwieckz illwieckz commented on Unvanquished/Unvanquished#2861 · December 4, 2023 21:34

Submodules are painful when they are parts of the main project (like the unvanquished dpkdir), but for a lib we would only update when there is a s…

@illwieckz illwieckz commented on DaemonEngine/Daemon#982 · December 4, 2023 21:00

One thing that can be used for decision is like “if gcc-based or clang-based (but not pnacl), enable PCH”.

@illwieckz illwieckz commented on DaemonEngine/Daemon#982 · December 4, 2023 20:57

The primary purpose of such detection is to print compiler versions in daemon.log for when we get bug reports.

@illwieckz illwieckz commented on DaemonEngine/Daemon#982 · December 4, 2023 20:55

The underlying version is useful, not for build-time decision (I simply concatenate it so it's not usable by CMake), but for bisecting bug that onl…

@slipher slipher commented on Unvanquished/Unvanquished#2861 · December 4, 2023 20:47

99.99999% of the time, we don't care about the history of the submodules too. Wouldn't that be a point in favor of submodules? With submodules yo…

@slipher slipher commented on DaemonEngine/Daemon#982 · December 4, 2023 20:21

But I want to know more, like make the difference between GCC and MinGW, between Clang, PNaCl, Saigo, Wasi, etc. CMake already knows about MinGW.…

@illwieckz illwieckz commented on DaemonEngine/Daemon#982 · December 4, 2023 20:18

Ah no I feel stupid, I need to use the target compilers, like pnacl-clang++ or x86_64-nacl-clang.

@illwieckz illwieckz commented on DaemonEngine/Daemon#982 · December 4, 2023 20:09

I tried to implement it a bit like I did for architectures: #define STRING(s) #s #define XSTRING(s) STRING(s) #define REPORT(key, value) \ "##REPOR…

@slipher slipher commented on DaemonEngine/Daemon#983 · December 4, 2023 19:36

It it's crashing by dereferencing in_nograb I guess we can fix it by migrating the cvar to Cvar::Cvar<bool>.

@DolceTriade DolceTriade commented on Unvanquished/unvanquished-infrastructure#36 · December 4, 2023 19:16

I haven't touched granger perms. Probably a remnant of kharnov

@slipher slipher commented on DaemonEngine/Daemon#985 · December 4, 2023 19:15

I see in your branch you seem to be relying on defines. Does that still work at runtime or if the user replaces the linked so with another one, it…

@DolceTriade DolceTriade commented on Unvanquished/Unvanquished#2861 · December 4, 2023 19:15

I have a strong dislike of submodules and would prefer to avoid them. As slipher mentions, every submodule we add makes the dev experience more ann…

@DolceTriade DolceTriade commented on DaemonEngine/Daemon#985 · December 4, 2023 19:06

That said, I think it's a good idea for debugging purposes.

@DolceTriade DolceTriade commented on DaemonEngine/Daemon#985 · December 4, 2023 19:06

I see in your branch you seem to be relying on defines. Does that still work at runtime or if the user replaces the linked so with another one, it …

@illwieckz illwieckz commented on DaemonEngine/Daemon#982 · December 4, 2023 16:31

The proposed code parses compiler defines. It only parses things like -v output if the defines are not usable, for example: zig doesn't set any zi…

@illwieckz illwieckz commented on DaemonEngine/Daemon#985 · December 4, 2023 15:39

I believe the cvar way is a good idea because I assume we can populate the result with defines in the file that already includes the said library. W…

@slipher slipher opened an issue in DaemonEngine/Daemon · December 4, 2023 10:44
Library version info idea #985

I have a branch that adds a printdepversions that prints (if knowable) the header and binary versions for each of our external library dependencies…

@slipher slipher commented on DaemonEngine/Daemon#982 · December 4, 2023 10:25

I don't find it worth the hassle to have hundreds of lines of code attempting to parse the compiler's version output. Let's compare this with the a…

@illwieckz illwieckz commented on DaemonEngine/Daemon#983 · December 4, 2023 03:48

A simple way to reproduce the crash is to set SDL_VIDEODRIVER=wayland in environment while being on X11, this way the game finds no display, so we …

@illwieckz illwieckz pushed to DaemonEngine/Daemon · December 4, 2023 03:41
2 commits to illwieckz/compiler-string/sync
  • @illwieckz e1cf4e9
    cmake/CustomCompiler: recognize MinGW64 and MinGW32
  • @illwieckz 0ec762c
    cmake/CustomCompiler: support compiler subcommands for reporting unde…
  • 22 more commits »
@illwieckz illwieckz commented on DaemonEngine/Daemon#984 · December 4, 2023 02:49

We may have not fix for this one and the bug may be in SDL anyway. This thread is just to not forget™.

@illwieckz illwieckz commented on DaemonEngine/Daemon#984 · December 4, 2023 02:43

Actually this crash may explain the GLVND bug, as it reports SDL2 tries to do some Wayland stuff, but I don't run Wayland, there is no display beca…

@illwieckz illwieckz opened an issue in DaemonEngine/Daemon · December 4, 2023 02:42
Engine crashes in error window if there is no display. #984

This is minor because if we can't render the game and can't render the error window, the user can't see anything anywyay, but the engine should not…

@illwieckz illwieckz opened an issue in DaemonEngine/Daemon · December 4, 2023 02:35
The engine crashes in input code if no display is available #983

The engine crashes in input code if no display is available This is not a big issue because the game can't run anyway, but the engine should shutdo…

@illwieckz illwieckz deleted branch illwieckz/broken-glcontext in DaemonEngine/Daemon · December 4, 2023 02:31

Updated Dec 5

@illwieckz illwieckz merged DaemonEngine/Daemon#976 · December 4, 2023 02:31
sdl_glimp: detect broken OpenGL context returned by SDL #976

sdl_glimp: detect broken OpenGL context returned by SDL This is meant to detect bugs like: #945

+78 -6
15 comments
@illwieckz illwieckz pushed to DaemonEngine/Daemon · December 4, 2023 02:31
2 commits to master
@illwieckz illwieckz pushed to DaemonEngine/Daemon · December 4, 2023 02:06
1 commit to illwieckz/broken-glcontext
  • @illwieckz 20dd7f4
    cmake: set Linux OpenGL ABI to LEGACY if OpenGL_GL_PREFERENCE is not set
@slipher slipher commented on DaemonEngine/Daemon#976 · December 4, 2023 02:03
@illwieckz illwieckz commented on DaemonEngine/Daemon#976 · December 4, 2023 01:53

Right! But I may even do further! What do you think about my latest fixup commit?

@illwieckz illwieckz pushed to DaemonEngine/Daemon · December 4, 2023 01:53
2 commits to illwieckz/broken-glcontext
@slipher slipher commented on DaemonEngine/Daemon#976 · December 4, 2023 01:20

Setting OpenGL_selected_LIBRARY here is unneeded

@slipher slipher pushed to DaemonEngine/Daemon · December 4, 2023 01:13
2 commits to master
@slipher slipher merged DaemonEngine/Daemon#979 · December 4, 2023 01:13
Actually disable PCH when Ninja generator is used #979

The code that was supposed to turn it off by default didn't work.

+6 -17
@illwieckz illwieckz pushed to Unvanquished/Unvanquished · December 4, 2023 00:02
1 commit to master
Daemon Engine
Daemon Engine
Sunday, 03 December 2023
@illwieckz illwieckz pushed to DaemonEngine/Daemon · December 3, 2023 23:57
2 commits to illwieckz/saigo/sync
@illwieckz illwieckz commented on DaemonEngine/Daemon#976 · December 3, 2023 23:55

Now, setting a preference guarantees that what is requested is given. It deviates a bit from CMake default behaviour, but at least the behaviour is…

@illwieckz illwieckz commented on DaemonEngine/Daemon#976 · December 3, 2023 23:53

This was heavily rewritten, and if (NOT OpenGL_GL_PREFERENCE) block (or similar) doesn't exist anymore.

@illwieckz illwieckz deleted branch illwieckz/pnacl in DaemonEngine/Daemon · December 3, 2023 23:49

Updated Dec 4

@illwieckz illwieckz pushed to DaemonEngine/Daemon · December 3, 2023 23:49
2 commits to master
@illwieckz illwieckz merged DaemonEngine/Daemon#980 · December 3, 2023 23:49
cmake/DaemonGame: make code more reusable for other toolchains #980

Very minor. When toying with Saigo I noticed this code could be factored: the PLATFORM_EXE_SUFFIX is set in the toolchain file so there is no need …

+17 -25
5 comments
@illwieckz illwieckz pushed to DaemonEngine/Daemon · December 3, 2023 23:48
1 commit to illwieckz/compiler-string/sync
  • @illwieckz 4c02ffd
    cmake/CustomCompiler: improve version discovery of underlying clang a…
@illwieckz illwieckz pushed to DaemonEngine/Daemon · December 3, 2023 23:45
1 commit to illwieckz/compiler-string/sync
  • @illwieckz 9cd65a3
    cmake/CustomCompiler: improve version discovery of underlying clang a…
@illwieckz illwieckz pushed to DaemonEngine/Daemon · December 3, 2023 23:38
1 commit to illwieckz/compiler-string/sync
  • @illwieckz 83edfb5
    cmake/CustomCompiler: improve version discovery of underlying clang a…
@illwieckz illwieckz pushed to DaemonEngine/Daemon · December 3, 2023 23:01
1 commit to illwieckz/compiler-string/sync
  • @illwieckz f1e72ef
    cmake/CustomCompiler: optimize the code
@cu-kai cu-kai commented on Unvanquished/Unvanquished#2863 · December 3, 2023 21:58

It doesn't fix #2472. I have tested this patch against my branch and on the map grangermaze.

@illwieckz illwieckz commented on DaemonEngine/Daemon#982 · December 3, 2023 19:58

MinGW is now detected too: -- Detected architecture: amd64 -- CMake generator: Unix Makefiles -- Detected C compiler: MinGW64 12-posix/gcc-12.0.0 -…

@illwieckz illwieckz pushed to DaemonEngine/Daemon · December 3, 2023 19:58
2 commits to illwieckz/compiler-string/sync
  • @illwieckz 9effab9
    cmake: enable PCH on all clang-based compilers that are not PNaCl, en…
  • @illwieckz 06ca571
    cmake/CustomCompiler: report underlying gcc used by custom compiler
  • 1 more commit »
@illwieckz illwieckz pushed to DaemonEngine/Daemon · December 3, 2023 19:56
2 commits to illwieckz/compiler-string/sync
  • @illwieckz 9385ec6
    cmake: enable PCH on all clang-based compilers that are not PNaCl, en…
  • @illwieckz 254cab7
    cmake/CustomCompiler: report underlying gcc used by custom compiler
  • 7 more commits »
@illwieckz illwieckz commented on Unvanquished/Unvanquished#2864 · December 3, 2023 19:13

What is the function used to init the cgame when in main menu? It looks like CG_Init() is only called when connected to a server. At least, the Log…

@illwieckz illwieckz pushed to DaemonEngine/Daemon · December 3, 2023 19:07
2 commits to illwieckz/compiler-string/sync
  • @illwieckz f5eb9db
    cmake: enable PCH on all clang-based compilers that are not PNaCl, en…
  • @illwieckz 656fe0f
    cmake/CustomCompiler: support compiler subcommands for reporting unde…
  • 2 more commits »
@illwieckz illwieckz pushed to DaemonEngine/Daemon · December 3, 2023 19:02
2 commits to illwieckz/compiler-string/sync
  • @illwieckz 68a14f1
    cmake: enable PCH on all clang-based compilers that are not PNaCl, en…
  • @illwieckz bee3de3
    cmake/CustomCompiler: support compiler subcommands for reporting unde…
  • 2 more commits »
@illwieckz illwieckz pushed to Unvanquished/Unvanquished · December 3, 2023 19:00
1 commit to illwieckz/compiler-string/sync
  • @illwieckz 43147d0
    cgame,sgame: report wich compiler was used to build the game
@illwieckz illwieckz commented on DaemonEngine/Daemon#982 · December 3, 2023 18:56

Actually this don't detect MingW as a variant of GCC: -- Detected architecture: amd64 -- CMake generator: Ninja -- Detected C compiler: GNU 9.3.0 -…

@illwieckz illwieckz commented on DaemonEngine/Daemon#982 · December 3, 2023 18:50

When building we get logs like that: -- Detected architecture: amd64 -- CMake generator: Unix Makefiles -- Detected C compiler: GNU 13.2.0 -- Detec…

@illwieckz illwieckz opened DaemonEngine/Daemon#982 · December 3, 2023 18:24
Report what compiler is used to build the game #982

Those are old commits that were sitting on my hard drive for a long time. I believe I wrote them when we were investigating the console bug that on…

+279 -11
@illwieckz illwieckz commented on DaemonEngine/Daemon#981 · December 3, 2023 13:51

At first I hoped this was for building the NaCl libc. 🥲️

@slipher slipher commented on DaemonEngine/Daemon#981 · December 3, 2023 11:44

You can find the old repository with scripts and sometimes patches for building the PNaCl libraries here. Also there is a nice summary.

@slipher slipher commented on Unvanquished/Unvanquished#2861 · December 3, 2023 09:19

Right now non-Windows curses are expected to be provided by system on Linux, or built as part of external deps in release scripts, and to be ship…

@slipher slipher opened Unvanquished/Unvanquished#2863 · December 3, 2023 05:33
Simplify attack warning location lookup #2863

The commit Simplify EV_WARN_ATTACK location lookup might not fix #2472 (I haven't really tried to reproduce it), but at least it makes things simpl…

+7 -5
@slipher slipher opened an issue in UnvanquishedAssets/map-thunder_src.dpkdir · December 3, 2023 05:17
Bad shader remap #6

I get this warning as soon as the map starts: Warn: Couldn't find image file 'textures/thunder/blend' Warn: R_RemapShader: new shader textures/thun…

@slipher slipher commented on Unvanquished/Unvanquished#2861 · December 3, 2023 03:47

I suppose another thing that makes external_deps unfavorable is if it's something needed to build the engine on Linux. The desire to build somethin…

@illwieckz illwieckz pushed to DaemonEngine/Daemon · December 3, 2023 02:52
2 commits to illwieckz/saigo/sync
  • @illwieckz 61b44c2
    cmake: building nexe against zlib is only required by cgame because o…
  • @illwieckz e5f36db
    cmake: use PIE option specific to game building
@illwieckz illwieckz pushed to Unvanquished/Unvanquished · December 3, 2023 02:49
1 commit to illwieckz/saigo/sync
  • @illwieckz 312035a
    cmake: use PIE option specific to game building
@illwieckz illwieckz pushed to DaemonEngine/Daemon · December 3, 2023 02:49
2 commits to illwieckz/saigo/sync
  • @illwieckz 7144715
    cmake: building nexe against zlib is only required by cgame because o…
  • @illwieckz 3af428e
    cmake: use PIE option specific to game building
@illwieckz illwieckz pushed to DaemonEngine/Daemon · December 3, 2023 02:26
2 commits to illwieckz/saigo/sync
  • @illwieckz aef7d81
    cmake: building nexe against zlib is only required by cgame because o…
  • @illwieckz 732e7f3
    cmake: when building the game, use PIE option set by the toolchain
@illwieckz illwieckz pushed to Unvanquished/Unvanquished · December 3, 2023 02:24
1 commit to illwieckz/saigo/sync
  • @illwieckz b798ab2
    cmake: when building the game, use PIE option set by the toolchain if…
@illwieckz illwieckz commented on DaemonEngine/Daemon#981 · December 3, 2023 02:08

Currently the sgame builds on all architectures. I have tested the amd64 sgame and it runs. The cgame builds on all architectures but the final lin…

@illwieckz illwieckz pushed to DaemonEngine/Daemon · December 3, 2023 02:02
2 commits to illwieckz/saigo/sync
  • @illwieckz dbb5697
    cmake: building nexe against zlib is only required by cgame because o…
  • @illwieckz c0ba605
    cmake: use PIE option set by the toolchain if set when building the game
  • 7 more commits »
@illwieckz illwieckz opened DaemonEngine/Daemon#981 · December 3, 2023 02:02
WIP: Saigo toolchain #981

Continuing the work done in: #971 How to use Get the Saigo toolchain, see: #795 (comment) Symlink the native_client/toolchain/linux_x86/saigo_n…

+226 -72
@illwieckz illwieckz commented on DaemonEngine/Daemon#980 · December 3, 2023 01:58

I added a commit: cmake/DaemonNacl: fix an error message

@illwieckz illwieckz created a branch in DaemonEngine/Daemon · December 3, 2023 01:56
@illwieckz illwieckz deleted branch illwieckz/saigo in DaemonEngine/Daemon · December 3, 2023 01:55

Updated Dec 3

@illwieckz illwieckz commented on DaemonEngine/Daemon#971 · December 3, 2023 01:55

I close this to reopen it with another branch name.

@illwieckz illwieckz closed DaemonEngine/Daemon#971 · December 3, 2023 01:55
WIP: Saigo toolchain #971

DO NOT MERGE THIS This PR only exists because yesterday I toyed with the Saigo toolchain to change my mind, and then I thought I can still share th…

+211 -68
19 comments
@illwieckz illwieckz pushed to DaemonEngine/Daemon · December 3, 2023 01:54
1 commit to illwieckz/pnacl
  • @illwieckz 173a73e
    cmake/DaemonNacl: fix an error message
@illwieckz illwieckz commented on DaemonEngine/Daemon#971 · December 3, 2023 00:45

Hmmm, removing -fPIC from the command seems to make this command work: ( cd /home/illwieckz/dev/Unvanquished/build/vms-saigo/nacl-vms-armhf/daemon_…

@illwieckz illwieckz commented on DaemonEngine/Daemon#971 · December 3, 2023 00:37

Setting the right define helps in no way: [ 1%] Building CXX object daemon_build/CMakeFiles/srclibs-nacl-module.dir/libs/nacl/native_client/src/sha…

@illwieckz illwieckz pushed to DaemonEngine/Daemon · December 3, 2023 00:35
2 commits to illwieckz/saigo
  • @illwieckz 3ee668c
    cmake/DaemonNacl: fix an error message
  • @illwieckz 5e00498
    cmake/DaemonNacl: set proper NaCl architecture for the target
@illwieckz illwieckz commented on DaemonEngine/Daemon#971 · December 3, 2023 00:23

This looks fishy: -DNACL_BUILD_ARCH=x86 -DNACL_BUILD_SUBARCH=64 We have this in DaemonNacl.cmake: if( NACL ) # Build nexe binary. # Those defines l…

@illwieckz illwieckz commented on DaemonEngine/Daemon#971 · December 3, 2023 00:20

More details: [ 2%] Building CXX object CMakeFiles/srclibs-recast.dir/libs/recastnavigation/Recast/Source/RecastAlloc.cpp.obj /home/illwieckz/dev/U…

@illwieckz illwieckz commented on DaemonEngine/Daemon#971 · December 3, 2023 00:17

Well, this one is even more mysterious: [ 2%] Building CXX object CMakeFiles/srclibs-recast.dir/libs/recastnavigation/Recast/Source/RecastAlloc.cpp…

@illwieckz illwieckz commented on DaemonEngine/Daemon#971 · December 3, 2023 00:09

Here is an example of compilation error happening when trying to build the sgame as arm nexe: [ 1%] Building C object daemon_build/CMakeFiles/srcli…

Unvanquished
Unvanquished
Saturday, 02 December 2023
@illwieckz illwieckz commented on Unvanquished/Unvanquished#2472 · December 2, 2023 22:17

After an intensive testing session with @cu-kai it really behaves like if the game would use a wrong index in an entity array, printing location of…

@illwieckz illwieckz commented on Unvanquished/Unvanquished#2861 · December 2, 2023 20:21

So maybe we may do: Unvanquished/daemon/libs/→freetype Unvanquished/daemon/libs/→libpng Unvanquished/libs/→lua

@illwieckz illwieckz commented on Unvanquished/Unvanquished#2861 · December 2, 2023 20:19

Actually FreeType is not that big… $ du -shc */.git 31M freetype/.git 44M libpng/.git 12M lua/.git 86M total

@illwieckz illwieckz commented on Unvanquished/Unvanquished#2861 · December 2, 2023 20:17

I noticed that FreeType has a CMakeLists.txt file which is nice but GitLab reports 1 GiB Project Storage, which is not nice. The libpng also has a C…

@illwieckz illwieckz commented on Unvanquished/Unvanquished#2861 · December 2, 2023 20:11

Lua is not and will not be used by the engine. Right. So that can be an Unvanquished submodule. libpng is supposedly a dependency of freetype. T…