VReaperV commented Oct 5, 2024

No idea, I was told that Adrenain had to be uninstalled because it was apparently hard-locking in unv after some Adrenalin update, and that they're…

illwieckz commented Oct 5, 2024

Since the weapon actually fires a muzzle flash sprite, we may actually add a dynamic light that works, instead. For consistency. The lcannon doesn'…

VReaperV commented Oct 5, 2024

(moved from review since this would require targeting for-0.55) This: Daemon/src/engine/renderer/tr_backend.cpp Line 2696 in 14e7fb0 app…

illwieckz commented Oct 5, 2024

textures were configured to be invisible using a black texture with blendfunc add. Lol it even duplicated a black image for every flash instead o…

illwieckz commented Oct 5, 2024

Apparently not Adrenalin What does that mean? Does that mean the AMD proprietary driver is not Adrenalin? or that Adrenalin is not buggy? Is ther…

VReaperV commented Oct 5, 2024

Apparently not Adrenalin, but I don't think that changes anything here, it should still be disabled on non-Mesa ATI, regardless of if running in Wine.

slipher commented Oct 5, 2024

The flamer "projectile" is a muzzle flash particle system. The actual missile is invisible.

slipher commented Oct 5, 2024

Apparently at some point, a subset of non-blob shadows were made to work while tiled mode was enabled, by just using the forward lighting code for …

slipher commented Oct 5, 2024

Automatic fading for all particles (other than ones that don't use alpha blending, where a depth fade is calculated but has no effect) was implemen…

slipher commented Oct 5, 2024

LGTM

slipher commented Oct 5, 2024

LGTM

slipher commented Oct 5, 2024

I think setting the latch flag for these is more misleading than enlightening, since there are 2 VMs which can be restarted independently. For exam…

VReaperV commented Oct 4, 2024

From dev channel: in fact, iirc, there is even a warning printed in the console about missing bindless texture extension when you launch unv on a mac

VReaperV commented Oct 4, 2024

Yes Thanks for the confirmation. This can then set foundOglp to true.

illwieckz commented Oct 4, 2024

Maybe with Mesa zink over MoltenVK over Metal, but then it's Mesa, and then not the Apple AMD/ATI driver. 😄️

cu-kai commented Oct 4, 2024

Yes bindless texture does not work on macOS and probably never will.

VReaperV commented Oct 4, 2024

AFAIK Apple is stuck on 4.1 completely due to their petty bullshit of trying to push Metal.

VReaperV commented Oct 4, 2024

I've received a report that it's also not working on the windows AMD proprietary driver (which is the Adrenalin one I guess).

VReaperV commented Oct 4, 2024

Yeah, zFar is supposed to cover the whole map in whatever direction, while zNear can change for portals. depthtile1_vp does this, albeit with r_zNear…

VReaperV commented Oct 4, 2024

@illwieckz Any thoughts on the above? Maybe another approach?

VReaperV commented Oct 4, 2024

If you go on NUKING the r_highPrecisionRendering test on light tile, better add a comment saying that “it's not about representing more or less co…

VReaperV commented Oct 4, 2024

I also wondered if such alternative code would help if one day we optionally target OpenGL ES as a fallback, it looks like none of those extensi…

VReaperV commented Oct 4, 2024

Hmm, I thought I did replace it with tabs. Maybe I changed some setting in my IDE that converted it into spaces, I'll recheck this later.

illwieckz commented Oct 4, 2024

Same concern about tabs.

illwieckz commented Oct 4, 2024

It looks like you're actually rewriting the whole file so I prefer if you use this opportunity to switch to tabs.

illwieckz commented Oct 4, 2024

I don't think r_highPrecisionRendering should affect the lighttile texture anyway. After all, it's not about representing more or less colours/dep…

illwieckz commented Oct 4, 2024

I also wondered if such alternative code would help if one day we optionally target OpenGL ES as a fallback, it looks like none of those extensio…

VReaperV commented Oct 4, 2024

More detailed example: I don't think r_highPrecisionRendering should affect the lighttile texture anyway. After all, it's not about representing …

VReaperV commented Oct 4, 2024

One interest in the alternate code to EXT_texture_integer is that it allows to use RGBA8 textures instead of RGBA32UI ones and then, use less VRAM…

VReaperV commented Oct 4, 2024

I also wondered if such alternative code would help if one day we optionally target OpenGL ES as a fallback, it looks like none of those extension…

illwieckz commented Oct 4, 2024

More detailed example: ]/r_highPrecisionRendering on ]/vid_restart ]/listImages _*tile*Render -----------------------------------------------------…

illwieckz commented Oct 4, 2024

One interest in the alternate code to EXT_texture_integer is that it allows to use RGBA8 textures instead of RGBA32UI ones and then, use less VRAM.…

illwieckz commented Oct 4, 2024

I also wondered if such alternative code would help if one day we optionally target OpenGL ES as a fallback, it looks like none of those extensions…

illwieckz commented Oct 4, 2024

Done.

illwieckz commented Oct 4, 2024

It now uses Sys::Error, I also modified the code to use Sys:Error on other critical file lookup.

illwieckz commented Oct 4, 2024

I was thinking about it but in the future I want to have a dumCvars command that would write some dump.txt file (basically doing this the non-hacky…

illwieckz commented Oct 4, 2024

Awesome work, it works on my end, it even fixes the distortion of metro chain sprite. I'm not sure the lighting of the chain is correct, but that'…

slipher commented Oct 4, 2024

I changed the target branch to 0.55 since this significantly changes the display of assets. It's ready to review and merge. I'm continuing to work …

illwieckz commented Oct 3, 2024

That looks ready to me:

illwieckz commented Oct 3, 2024

Ah no, it's just that Urcheon doesn't (yet) invalidates the iqm build if the .iqe.cfg file is modified, the scaling is done: I even can adjust it …

illwieckz commented Oct 3, 2024

Something is very wrong, setting a scale of .001 does nothing…

illwieckz commented Oct 3, 2024

I still get the being model too big, that's is very weird.

VReaperV commented Oct 3, 2024

Okay, closing this then.

illwieckz commented Oct 3, 2024

yes, it is now meant to be obsoleted by #1335

VReaperV commented Oct 3, 2024

So this is to be considered obsolete then?

illwieckz commented Oct 3, 2024

That would have conflicted with #1335 But since that was not the only mistake, I also implemented the bindless enablement fix in #1335 and fixed th…

VReaperV commented Oct 3, 2024

I've opened an issue for it: #1339. I consider that out of scope here though, since this pr is about logging.

VReaperV commented Oct 3, 2024

A quick and dirty fix would be to add 3 commented out lines for every disabled macro, and then just add 3 lines to the count for #insert. Another o…

VReaperV commented Oct 3, 2024

So I checked everything again and it turns that what was throwing me off were the shader compile macros. They're never passed to InitShader(), but …

illwieckz commented Oct 3, 2024

I guess this should have been merged when Unvanquished/Unvanquished#2901 was: Unvanquished/Unvanquished#2901

slipher commented Oct 3, 2024

LGTM

slipher commented Oct 3, 2024

Seemed like more effort than it's worth since I would have to plumb through the near/far values (which can apparently be different for every view) …

illwieckz commented Oct 3, 2024

I suppose this belongs on a for-0.55.0 branch Done.

illwieckz commented Oct 3, 2024

Fixed.

illwieckz commented Oct 3, 2024

Oh lol yes. 🤣️

slipher commented Oct 3, 2024

It's commented out

VReaperV commented Oct 3, 2024

Why not linearize it then? I assume the different fading based on near/far plane etc. is not intended.

slipher commented Oct 3, 2024

I guess the command tool version could just be a shell script then.

illwieckz commented Oct 3, 2024

Any other implementation that does the same thing may work, indeed. The nice thing with that external tool is that it's testable from outside dæmon…

VReaperV commented Oct 3, 2024

Yep, fixed now.