DolceTriade commented Jun 9, 2023

LGTM

sweet235 commented Jun 9, 2023

the stuff to list recent buildings changes You mean buildlog. I'd say that GUI for admin stuff has the lowest priority of all GUI proposals.

slipher commented Jun 9, 2023

It seems the bug is in our code this time. SelectableDataGrid (from src/cgame/rocket/rocketSelectableDataGrid.h) has a deleted element in lastSelec…

illwieckz commented Jun 9, 2023

Great! Catching it on dll is useful because it makes easier to debug!

slipher commented Jun 9, 2023

I can reproduce it with a MSVC DLL too, just took more tries. Looks like a similar bug to the crashes we had in the circle menus where something tr…

slipher commented Jun 9, 2023

OK now I got it. I didn't understand that I have to click on a server before refreshing.

Gireen commented Jun 8, 2023

I can also reproduce it with the nameless server. It either needs one more refresh or happens instantly after the crash once occurred. Over all it …

illwieckz commented Jun 8, 2023

I remind that I only reproduce the bug with nexe cgame, not with dll and exe ones. I don't know how I got the backtrace in first post.

illwieckz commented Jun 8, 2023

Right it's very consistent to me by doing this way: open server list select a server in the list click refresh select again the same server in the…

illwieckz commented Jun 8, 2023

I reproduce on 0.54.0 and current master. Here is a video of me reproducing the bug on master: 20230608-124218-000.unvanquished-server-refresh-cra…

sweet235 commented Jun 8, 2023

From private communication, rephrased: the [modest] code duplication from BotTargetInAttackRange to TargetInOffmeshAttackRange is ugly. That is cor…

slipher commented Jun 8, 2023

Changing the aliens' range seems like a better solution. I'm not sure how the alien attack traces work but assuming it's an AABB maybe you can make…

sweet235 commented Jun 8, 2023

From IRC: this is missing the flamer case

sweet235 commented Jun 8, 2023

LGTM

slipher commented Jun 8, 2023

I can't reproduce this with 0.54.0. I don't recall ever seeing it in the past either.

illwieckz commented Jun 7, 2023

Nice! Thanks for taking care of this! 🙂️

slipher commented Jun 7, 2023

I finally understood what's going on with the server listing code. It already is capable of spreading out ping packets over multiple frames, and ha…

slipher commented Jun 7, 2023

I have yet to find out how to observe beacons without my observation influencing the beacons. All right, I made it so that you can use noclip to …

sweet235 commented Jun 7, 2023

This gives us the cartesian product of possible bot bugs and beacon bugs to deal with if a bot fails to attack. I feel like there is at least one b…

slipher commented Jun 7, 2023

The mouse pointer is not blocked. But anyway we should populate it incrementally so that a slow pinging feature to fix #654 would not result in exc…

slipher commented Jun 7, 2023

Is this OK to merge?

illwieckz commented Jun 6, 2023

Interesting? What would be good would be to not block the mouse pointer, even if the list is populated at once at the end of the fetch.

slipher commented Jun 6, 2023

The UI is not actually blocked(*)... it just chooses not to display any results until all pings have completed or timed out. This can be demonstrat…

bmorel commented Jun 4, 2023

Then I guess an infostring could be added to give more complete info to server browser applications in JSon, while the pinging would use a differen…

slipher commented Jun 4, 2023

@bmorel, that is correct. Well, it is not 100% free-form as you can't use \ or ; characters... Still, the overhead of setting up a JSON library and…

bmorel commented Jun 4, 2023

I don't see how changing a format (json is not a protocol) would change anything. From what I understand, infostrings are key->values pairs, like a…

slipher commented Jun 4, 2023

Oh my. I'm still not sure this is all a good idea to violently terminate the game like this, but hey. Well I haven't heard any complaints about t…

Gireen commented Jun 4, 2023

Is it for unv possible to download a JSON file and pass it to the client lua? Then we could use json on top of the current format. the masterserver…

slipher commented Jun 2, 2023

I suggest naming it g_bot_alienAimDelay. With "modifier" it's unclear whether a higher number means better or worse aiming. Description could be li…

bmorel commented Jun 2, 2023

weird, I'm certain I got all submodules updated, and tried several times. I'll give it another shot in few hours and will try to dig more if I stil…

slipher commented Jun 2, 2023

It worked for me. As I mentioned above, I successfully tested the rotating thing with a map-mission-one-b7_0.0.2.dpk

bmorel commented Jun 2, 2023

I'm not teleported to the correct place, which is on one of the rotating things that had the bug.

slipher commented Jun 2, 2023

@slipher pasting this set of commands in the console normally sends the player to a specific position, which allows to check quickly if the collis…

bmorel commented Jun 2, 2023

nitpick.

bmorel commented Jun 2, 2023

nitpick.

bmorel commented Jun 2, 2023

nitpick.

bmorel commented Jun 2, 2023

and I think it also breaks an invariant that Str::StringRef are never pointing to nullptr, or that len == strlen(str). If you ran tests more ofte…

bmorel commented Jun 2, 2023

I see my disagreement was ignored. Noted.

bmorel commented Jun 2, 2023

@slipher pasting this set of commands in the console normally sends the player to a specific position, which allows to check quickly if the collisi…

illwieckz commented Jun 2, 2023

Is there any risk that, the crash triggers an annoying windows pop-up like “we are investigating what happened… click here to send the report”? th…

slipher commented Jun 2, 2023

I think admin commands make sense but if you don't want to deal with that, there's a third command list in sg_svcmds.cpp that can only be used by t…

slipher commented Jun 2, 2023

Nit: I think the algorithm would be cleaner if there was a separate function that collects all the base skills and ChooseOneSkill only chooses rand…

DolceTriade commented Jun 2, 2023

lgtm

slipher commented Jun 2, 2023

I think it would make more sense to parse them into bitsets here, so that you can have a one-time warning about invalid skill names.

necessarily-equal commented Jun 2, 2023

I think you can remove the = Cvar::Cvar<bool> part of these lines

necessarily-equal commented Jun 2, 2023

I think you can remove the = Cvar::Cvar<…> part of this line

necessarily-equal commented Jun 2, 2023

I think you can remove the = Cvar::Cvar<…> part of these lines

necessarily-equal commented Jun 2, 2023

: ptr(other), len(len_) { ASSERT_EQ( len_, std::char_traits<T>::length(other) ); }

necessarily-equal commented Jun 2, 2023

@slipher said in #2697 (comment): The output [of the listing commands] is implemented wrong on those btw, they are registered as networked command…

necessarily-equal commented Jun 2, 2023

Oh I also wanted to say that if we want to make the skill list per-level for the release, then this is what really matters for this release and thi…

necessarily-equal commented Jun 2, 2023

It's true that it could have been merged earlier, but I don't think it's too late. Most of your argument seems to be about the line count. It's act…

slipher commented Jun 2, 2023

Could you add more detail aroudn what's wrong in the bugged vrsion in the commit message? Done. on this branch, running /setviewpos -3950 2193 3…

slipher commented Jun 2, 2023

Yeah I don't think the PR helps anything.

bmorel commented Jun 1, 2023

Note that this does not happens with telenodes when this is applied.

bmorel commented Jun 1, 2023

As @sweet235 asked me if that would trigger the bug of tyrant unable to hit medistation under them, I tried it. To my surprise (I had not thought a…

Viech commented Jun 1, 2023

I wanted to see how far the feet sink in. 😉

bmorel commented Jun 1, 2023

as for what it looks like when someone is on it, requested by @Viech on IRC:

bmorel commented Jun 1, 2023

on this branch, running /setviewpos -3950 2193 3; noclip; devteam a no longer works.

bmorel commented Jun 1, 2023

Ok then. I think this is all a bit confusing, and don't see what this PR would break or make slower, though. But if you really consider this a bad …

bmorel commented Jun 1, 2023

so, we're going to merge more experiments with a release approaching soon and the AI problem considered blocking? I think it is bad idea.

DolceTriade commented Jun 1, 2023

lgtm

DolceTriade commented Jun 1, 2023

LGTM. Could you add more detail aroudn what's wrong in the bugged vrsion in the commit message?

slipher commented Jun 1, 2023

To find the optimal bounds you would need to compute the mins/maxs over all 8 corners of the rotated box, unlike that code which just checks 2 of …

slipher commented Jun 1, 2023

ec4df1d is in fact geometrically wrong. Not sure why I LGTMed it the first time :) To find the optimal bounds you would need to compute the mins/ma…

slipher commented Jun 1, 2023

LGTM

slipher commented Jun 1, 2023

StringRef is intentionally different from string_view. StringRef is supposed to be a C-string, i.e. a pointer to a null-terminated byte sequence. E…