Unvanquished Development activity

Events from:

@sweet235 sweet235 opened an issue in Unvanquished/Unvanquished · June 9, 2023 16:13
Wall climbing alien bots can be blocked by a building on top #2729

Dretch and mantis will activate the wall climb when following a navcon that leads upwards. Usually, these navcons will be placed such that these bo…

@sweet235 sweet235 commented on Unvanquished/Unvanquished#2716 · June 9, 2023 15:46

the stuff to list recent buildings changes You mean buildlog. I'd say that GUI for admin stuff has the lowest priority of all GUI proposals.

@slipher slipher opened Unvanquished/Unvanquished#2728 · June 9, 2023 06:33
+32 -2
@slipher slipher commented on Unvanquished/Unvanquished#2149 · June 9, 2023 02:30

It seems the bug is in our code this time. SelectableDataGrid (from src/cgame/rocket/rocketSelectableDataGrid.h) has a deleted element in lastSelec…

@illwieckz illwieckz commented on Unvanquished/Unvanquished#2149 · June 9, 2023 02:02

Great! Catching it on dll is useful because it makes easier to debug!

@slipher slipher commented on Unvanquished/Unvanquished#2149 · June 9, 2023 02:00

I can reproduce it with a MSVC DLL too, just took more tries. Looks like a similar bug to the crashes we had in the circle menus where something tr…

@slipher slipher commented on Unvanquished/Unvanquished#2149 · June 9, 2023 01:34

OK now I got it. I didn't understand that I have to click on a server before refreshing.

Unvanquished
Unvanquished
Thursday, 08 June 2023
@Gireen Gireen commented on Unvanquished/Unvanquished#2149 · June 8, 2023 23:29

I can also reproduce it with the nameless server. It either needs one more refresh or happens instantly after the crash once occurred. Over all it …

@illwieckz illwieckz commented on Unvanquished/Unvanquished#2149 · June 8, 2023 11:09

I remind that I only reproduce the bug with nexe cgame, not with dll and exe ones. I don't know how I got the backtrace in first post.

@illwieckz illwieckz commented on Unvanquished/Unvanquished#2149 · June 8, 2023 10:54

Right it's very consistent to me by doing this way: open server list select a server in the list click refresh select again the same server in the…

@illwieckz illwieckz commented on Unvanquished/Unvanquished#2149 · June 8, 2023 10:50

I reproduce on 0.54.0 and current master. Here is a video of me reproducing the bug on master: 20230608-124218-000.unvanquished-server-refresh-cra…

@sweet235 sweet235 commented on Unvanquished/Unvanquished#2727 · June 8, 2023 09:55

From private communication, rephrased: the [modest] code duplication from BotTargetInAttackRange to TargetInOffmeshAttackRange is ugly. That is cor…

@slipher slipher commented on UnvanquishedAssets/res-buildables_src.dpkdir#13 · June 8, 2023 08:50

Changing the aliens' range seems like a better solution. I'm not sure how the alien attack traces work but assuming it's an AABB maybe you can make…

@sweet235 sweet235 commented on Unvanquished/Unvanquished#2727 · June 8, 2023 08:47

From IRC: this is missing the flamer case

@sweet235 sweet235 opened Unvanquished/Unvanquished#2727 · June 8, 2023 08:15
human bots see an enemy: they shoot at it #2727

I am convinced that currently, bots will only pick an enemy as target if the enemy's position can be projected downwards onto the navmesh. This doe…

+85 -1
@slipher slipher closed an issue in Unvanquished/Unvanquished · June 8, 2023 06:58
Make bots use beacons to seek enemy buildings #2641

Bots' omniscience of enemy buildings is quite annoying because as soon as you build a new structure that's closer to the enemy base than existing s…

@slipher slipher pushed to Unvanquished/Unvanquished · June 8, 2023 06:58
2 commits to master
@slipher slipher merged Unvanquished/Unvanquished#2683 · June 8, 2023 06:58
Bots use beacons to locate enemy buildables #2683

Implement #2641 (the easy alternative #1). Specifically, this is just for the closestBuildings array. There are other ways bots can locate buildabl…

+59 -43
8 comments
@slipher slipher commented on Unvanquished/Unvanquished#2149 · June 8, 2023 04:39

I can't reproduce this with 0.54.0. I don't recall ever seeing it in the past either.

Daemon Engine
Daemon Engine
Wednesday, 07 June 2023
@illwieckz illwieckz commented on DaemonEngine/Daemon#283 · June 7, 2023 23:53

Nice! Thanks for taking care of this! 🙂️

@slipher slipher opened Unvanquished/Unvanquished#2726 · June 7, 2023 08:48
Invalidate GentityRef on player death #2726

The existing behavior is to be invalidated only when the client disconnects. The existing behavior turned out to be good enough to prevent some cra…

+7 -0
@slipher slipher commented on DaemonEngine/Daemon#283 · June 7, 2023 08:37

I finally understood what's going on with the server listing code. It already is capable of spreading out ping packets over multiple frames, and ha…

@slipher slipher opened Unvanquished/Unvanquished#2725 · June 7, 2023 08:08
Server list fixes #2725

Fix #1988 Fix DaemonEngine/Daemon#284 so that we will be able to address this later. I used DaemonEngine/Daemon#283 for testing the scenario that…

+48 -28
@slipher slipher commented on Unvanquished/Unvanquished#2683 · June 7, 2023 07:26

I have yet to find out how to observe beacons without my observation influencing the beacons. All right, I made it so that you can use noclip to …

@sweet235 sweet235 commented on Unvanquished/Unvanquished#2683 · June 7, 2023 06:54

This gives us the cartesian product of possible bot bugs and beacon bugs to deal with if a bot fails to attack. I feel like there is at least one b…

@slipher slipher commented on DaemonEngine/Daemon#284 · June 7, 2023 03:40

The mouse pointer is not blocked. But anyway we should populate it incrementally so that a slow pinging feature to fix #654 would not result in exc…

@slipher slipher closed Unvanquished/Unvanquished#2721 · June 7, 2023 01:45
Revert "Rotate bounding box correctly in G_CM_LinkEntity" #2721

This reverts commit ec4df1d. Said commit introduces the regression which is talked about in #2706 (comment) I only did quick testing (that I descri…

+8 -8
6 comments
@slipher slipher pushed to Unvanquished/Unvanquished · June 7, 2023 01:44
2 commits to master
  • @slipher b2d6d90
    Correctly calculate bounding box of rotated box
  • @slipher df0b224
    Fix bug with custom vote commands starting with "map"
@slipher slipher closed an issue in DaemonEngine/Daemon · June 7, 2023 01:43
OpenAL crash during shutdown #913

As of the external deps version 9 package, OpenAL causes a crash during shutdown. Microsoft's _exit implementation does not respect the spirit of e…

@slipher slipher closed an issue in DaemonEngine/Daemon · June 7, 2023 01:43
OpenAL crash during shutdown #913

As of the external deps version 9 package, OpenAL causes a crash during shutdown. Microsoft's _exit implementation does not respect the spirit of e…

@slipher slipher merged DaemonEngine/Daemon#914 · June 7, 2023 01:43
+8 -1
2 comments
@slipher slipher pushed to DaemonEngine/Daemon · June 7, 2023 01:43
1 commit to master
  • @slipher 07eda56
    Windows: really exit process immediately
Daemon Engine
Daemon Engine
Tuesday, 06 June 2023
@illwieckz illwieckz commented on DaemonEngine/Daemon#284 · June 6, 2023 11:37

Interesting? What would be good would be to not block the mouse pointer, even if the list is populated at once at the end of the fetch.

@slipher slipher commented on DaemonEngine/Daemon#284 · June 6, 2023 09:30

The UI is not actually blocked(*)... it just chooses not to display any results until all pings have completed or timed out. This can be demonstrat…

Unvanquished
Unvanquished
Sunday, 04 June 2023
@bmorel bmorel commented on Unvanquished/Unvanquished#2097 · June 4, 2023 08:55

Then I guess an infostring could be added to give more complete info to server browser applications in JSon, while the pinging would use a differen…

@slipher slipher commented on Unvanquished/Unvanquished#2097 · June 4, 2023 08:47

@bmorel, that is correct. Well, it is not 100% free-form as you can't use \ or ; characters... Still, the overhead of setting up a JSON library and…

@bmorel bmorel commented on Unvanquished/Unvanquished#2097 · June 4, 2023 07:22

I don't see how changing a format (json is not a protocol) would change anything. From what I understand, infostrings are key->values pairs, like a…

@slipher slipher merged DaemonEngine/Daemon#912 · June 4, 2023 04:19
Fix SDL2.dll copying for MSVC #912

#904 doesn't work... maybe I had already manually fixed it when I tried it then forgot

+1 -1
1 comment
@slipher slipher pushed to DaemonEngine/Daemon · June 4, 2023 04:19
1 commit to master
  • @slipher d6717bc
    Fix SDL2.dll copying for MSVC
@slipher slipher commented on DaemonEngine/Daemon#914 · June 4, 2023 04:15

Oh my. I'm still not sure this is all a good idea to violently terminate the game like this, but hey. Well I haven't heard any complaints about t…

@Gireen Gireen commented on Unvanquished/Unvanquished#2097 · June 4, 2023 01:10

Is it for unv possible to download a JSON file and pass it to the client lua? Then we could use json on top of the current format. the masterserver…

Unvanquished
Unvanquished
Saturday, 03 June 2023
@bmorel bmorel deleted branch optout-skillset in Unvanquished/Unvanquished · June 3, 2023 12:37
@bmorel bmorel closed Unvanquished/Unvanquished#2720 · June 3, 2023 12:37
make the skillset feature opt-out #2720

This works by adding a cvar named: g_bot_defaultSkill If this cvar is empty, which is the default, behavior won't change. Otherwise, it must be fil…

+90 -9
4 comments
@slipher slipher opened DaemonEngine/Daemon#915 · June 3, 2023 08:55
Server listing cleanup #915

Some cleanup in client's server listing code, in preparation to rewrite the server list API to fix #284, #654, etc.

+54 -186
Unvanquished
Unvanquished
Friday, 02 June 2023
@slipher slipher commented on Unvanquished/Unvanquished#2723 · June 2, 2023 19:03

I suggest naming it g_bot_alienAimDelay. With "modifier" it's unclear whether a higher number means better or worse aiming. Description could be li…

@bmorel bmorel commented on Unvanquished/Unvanquished#2724 · June 2, 2023 18:37

weird, I'm certain I got all submodules updated, and tried several times. I'll give it another shot in few hours and will try to dig more if I stil…

@slipher slipher commented on Unvanquished/Unvanquished#2724 · June 2, 2023 18:36

It worked for me. As I mentioned above, I successfully tested the rotating thing with a map-mission-one-b7_0.0.2.dpk

@bmorel bmorel commented on Unvanquished/Unvanquished#2724 · June 2, 2023 18:28

I'm not teleported to the correct place, which is on one of the rotating things that had the bug.

@slipher slipher commented on Unvanquished/Unvanquished#2724 · June 2, 2023 18:24

@slipher pasting this set of commands in the console normally sends the player to a specific position, which allows to check quickly if the collis…

@bmorel bmorel commented on DaemonEngine/Daemon#907 · June 2, 2023 15:24

and I think it also breaks an invariant that Str::StringRef are never pointing to nullptr, or that len == strlen(str). If you ran tests more ofte…

@bmorel bmorel commented on Unvanquished/Unvanquished#2722 · June 2, 2023 15:15

I see my disagreement was ignored. Noted.

@bmorel bmorel commented on Unvanquished/Unvanquished#2724 · June 2, 2023 15:12

@slipher pasting this set of commands in the console normally sends the player to a specific position, which allows to check quickly if the collisi…

@illwieckz illwieckz commented on DaemonEngine/Daemon#914 · June 2, 2023 12:34

Is there any risk that, the crash triggers an annoying windows pop-up like “we are investigating what happened… click here to send the report”? th…

@illwieckz illwieckz deleted branch illwieckz/case-semicolon in DaemonEngine/Daemon · June 2, 2023 11:42

Updated Jun 7

@illwieckz illwieckz pushed to DaemonEngine/Daemon · June 2, 2023 11:42
1 commit to master
  • @illwieckz 19f77e6
    external_deps: re-add a switch-case “;;” mistakenly removed
@illwieckz illwieckz merged DaemonEngine/Daemon#911 · June 2, 2023 11:42
external_deps: re-add a case “;;” mistakenly removed #911

It looks to have been mistakenly removed in 93d4c3e, likely a rebase error.

+1 -0
1 comment
@slipher slipher commented on Unvanquished/Unvanquished#2635 · June 2, 2023 08:25

I think admin commands make sense but if you don't want to deal with that, there's a third command list in sg_svcmds.cpp that can only be used by t…

@slipher slipher commented on Unvanquished/Unvanquished#2697 · June 2, 2023 08:21

Nit: I think the algorithm would be cleaner if there was a separate function that collects all the base skills and ChooseOneSkill only chooses rand…

@slipher slipher commented on Unvanquished/Unvanquished#2697 · June 2, 2023 07:58

I think it would make more sense to parse them into bitsets here, so that you can have a one-time warning about invalid skill names.

@necessarily-equal necessarily-equal commented on DaemonEngine/Daemon#905 · June 2, 2023 07:48

I think you can remove the = Cvar::Cvar<bool> part of these lines

@necessarily-equal necessarily-equal commented on DaemonEngine/Daemon#905 · June 2, 2023 07:47

I think you can remove the = Cvar::Cvar<…> part of this line

@necessarily-equal necessarily-equal commented on DaemonEngine/Daemon#905 · June 2, 2023 07:47

I think you can remove the = Cvar::Cvar<…> part of these lines

@necessarily-equal necessarily-equal commented on DaemonEngine/Daemon#907 · June 2, 2023 07:42

: ptr(other), len(len_) { ASSERT_EQ( len_, std::char_traits<T>::length(other) ); }

@necessarily-equal necessarily-equal commented on Unvanquished/Unvanquished#2635 · June 2, 2023 07:22

@slipher said in #2697 (comment): The output [of the listing commands] is implemented wrong on those btw, they are registered as networked command…

@necessarily-equal necessarily-equal commented on Unvanquished/Unvanquished#2722 · June 2, 2023 07:19

Oh I also wanted to say that if we want to make the skill list per-level for the release, then this is what really matters for this release and thi…

@necessarily-equal necessarily-equal merged Unvanquished/Unvanquished#2722 · June 2, 2023 07:16
Skilltree refactoring commits (4/?) #2722

It is needed for #2697 and #2635. Although the commits are new, the code change themselves date from mid-april. Next PR in this series: #2697

+94 -82
3 comments
@necessarily-equal necessarily-equal pushed to Unvanquished/Unvanquished · June 2, 2023 07:16
2 commits to master
  • @necessarily-equal 55ab347
    Refactor: move skilltree selection algorithm in its own function
  • @necessarily-equal 36358c0
    Refactor: flatten the skill tree structure and make it more declarative
@necessarily-equal necessarily-equal commented on Unvanquished/Unvanquished#2722 · June 2, 2023 07:11

It's true that it could have been merged earlier, but I don't think it's too late. Most of your argument seems to be about the line count. It's act…

@slipher slipher commented on Unvanquished/Unvanquished#2724 · June 2, 2023 06:20

Could you add more detail aroudn what's wrong in the bugged vrsion in the commit message? Done. on this branch, running /setviewpos -3950 2193 3…

@slipher slipher commented on DaemonEngine/Daemon#907 · June 2, 2023 06:11

Yeah I don't think the PR helps anything.

@slipher slipher opened an issue in DaemonEngine/Daemon · June 2, 2023 05:00
OpenAL crash during shutdown #913

As of the external deps version 9 package, OpenAL causes a crash during shutdown. Microsoft's _exit implementation does not respect the spirit of e…

@slipher slipher opened DaemonEngine/Daemon#912 · June 2, 2023 03:43
Fix SDL2.dll copying for MSVC #912

#904 doesn't work... maybe I had already manually fixed it when I tried it then forgot

+1 -1
Unvanquished Assets
Unvanquished Assets
Thursday, 01 June 2023
allow dragoons and bigger to hit medistat under them #13

This looks ugly in game, but it works around the problem of dragoons, adv dragoons and tyrants not able to hit medistat bellow them. Fix Unvanquish…

+1 -1
@bmorel bmorel commented on Unvanquished/Unvanquished#2505 · June 1, 2023 14:34

Note that this does not happens with telenodes when this is applied.

@bmorel bmorel commented on UnvanquishedAssets/res-buildables_src.dpkdir#12 · June 1, 2023 14:30

As @sweet235 asked me if that would trigger the bug of tyrant unable to hit medistation under them, I tried it. To my surprise (I had not thought a…

@Viech Viech commented on UnvanquishedAssets/res-buildables_src.dpkdir#12 · June 1, 2023 12:57

I wanted to see how far the feet sink in. 😉

@bmorel bmorel commented on UnvanquishedAssets/res-buildables_src.dpkdir#12 · June 1, 2023 12:22

as for what it looks like when someone is on it, requested by @Viech on IRC:

@bmorel bmorel commented on Unvanquished/Unvanquished#2724 · June 1, 2023 12:08

on this branch, running /setviewpos -3950 2193 3; noclip; devteam a no longer works.

@bmorel bmorel commented on DaemonEngine/Daemon#907 · June 1, 2023 11:56

Ok then. I think this is all a bit confusing, and don't see what this PR would break or make slower, though. But if you really consider this a bad …

@bmorel bmorel commented on Unvanquished/Unvanquished#2722 · June 1, 2023 11:53

so, we're going to merge more experiments with a release approaching soon and the AI problem considered blocking? I think it is bad idea.

@DolceTriade DolceTriade commented on Unvanquished/Unvanquished#2724 · June 1, 2023 08:14

LGTM. Could you add more detail aroudn what's wrong in the bugged vrsion in the commit message?

@illwieckz illwieckz opened DaemonEngine/Daemon#911 · June 1, 2023 08:09
external_deps: re-add a case “;;” mistakenly removed #911

It looks to have been mistakenly removed in 93d4c3e, likely a rebase error.

+1 -0
@slipher slipher commented on Unvanquished/Unvanquished#2721 · June 1, 2023 03:30

To find the optimal bounds you would need to compute the mins/maxs over all 8 corners of the rotated box, unlike that code which just checks 2 of …

@slipher slipher commented on Unvanquished/Unvanquished#2721 · June 1, 2023 02:58

ec4df1d is in fact geometrically wrong. Not sure why I LGTMed it the first time :) To find the optimal bounds you would need to compute the mins/ma…

@slipher slipher commented on DaemonEngine/Daemon#907 · June 1, 2023 01:16

StringRef is intentionally different from string_view. StringRef is supposed to be a C-string, i.e. a pointer to a null-terminated byte sequence. E…