Unvanquished Development activity

Events from:

Daemon Engine
Daemon Engine
Tuesday, 23 April 2024
@VReaperV VReaperV opened DaemonEngine/Daemon#1097 · April 23, 2024 11:15
Add sky surfaces to world VBO #1097

Stops tess.vertexes from overflowing by adding all the sky surfaces to world VBO instead of doing Tess_SurfaceVertsAndTris() on them. This essentia…

+3 -3

Spike29 (757a17fb) at 23 Apr 11:06

Merge branch 'NateEag-master-patch-12920' into 'master'

... and 1 more commit

@VReaperV VReaperV opened an issue in DaemonEngine/Daemon · April 23, 2024 09:21
@sweet235 sweet235 commented on Unvanquished/updater#104 · April 23, 2024 08:14

I have a feeling some portion of people will get mad that older DPKs are removed. What about all the people who are already mad because we never …

@slipher slipher opened Unvanquished/updater#119 · April 23, 2024 08:06
Fix desktop file not showing up in application list (Linux) #119

On my virtual machine GNOME is refusing to display desktop entries where TryExec is quoted. Indeed the spec only mentions quotes in Exec. Regressio…

+2 -2
@DolceTriade DolceTriade commented on Unvanquished/updater#117 · April 23, 2024 08:04

Is this actually required? I'd prefer to not have a hard dependency on the updater for Unvanquished. I think if you want to use the updater/launche…

@slipher slipher closed an issue in Unvanquished/updater · April 23, 2024 08:03
Splash screen sticks at top of z-order during self-update #69

The splash screen can't be moved or minimized and is drawn on top of any other windows. The splash screen is also displayed during the entire updat…

2 comments
@slipher slipher pushed to Unvanquished/updater · April 23, 2024 08:03
2 commits to master
@slipher slipher merged Unvanquished/updater#116 · April 23, 2024 08:03
UI fixes #116

Fix window stuck on top of everything else during self-update Wider custom command line text field Fix the possibility relaunching twice on Window…

+27 -2
@DolceTriade DolceTriade commented on Unvanquished/updater#118 · April 23, 2024 08:03

That's my feeling too. if enough people request it we can look at implementing it.

@DolceTriade DolceTriade commented on Unvanquished/updater#104 · April 23, 2024 08:00

The downside of deleting the existing dir is that you have to download everything. Currently, we only download new files and changed files.

@VReaperV VReaperV opened DaemonEngine/Daemon#1095 · April 23, 2024 07:47
Don't check overflow for data already in VBOs #1095

Overflow only makes sense when uploading new vertices, models that already have their vertices in vram will not overflow anything.

+2 -2
@slipher slipher commented on Unvanquished/updater#15 · April 23, 2024 04:19

Closing this as I assume no one can reproduce it.

@slipher slipher closed an issue in Unvanquished/updater · April 23, 2024 04:19
Hangs at near-completion: Error extracting update. #15

For me, the updater got stuck showing a progress of 740.3 / 740.7 MiB, 00:00:00 left, still showing DL: 4.9 MiB/s UL: 0.0 Byte/s while there is no …

4 comments
@illwieckz illwieckz commented on Unvanquished/updater#63 · April 23, 2024 02:30

Related to: #117 This also relates with another talk I had in the past, suggesting the updater would just be named “Unvanquished.exe”, considerin…

@slipher slipher commented on Unvanquished/updater#30 · April 23, 2024 01:15

The menu could offer a download and upload speed limit setting. A drop down menu with "unlimited" and a few options (a range/selection of powers o…

@slipher slipher closed an issue in Unvanquished/updater · April 23, 2024 01:15
Feedback on 982b53b. #30

There needs to be a guaranteed-to-be-writable default install location for every OS. For Linux (and maybe also Mac) it should be somewhere in ~ (…

5 comments
@slipher slipher opened an issue in Unvanquished/updater · April 23, 2024 01:06
Offer to move installation if install directory is changed #118

From #30 The reaction to changing the install location via the menu currently is that the old install location is abandoned and the game is re-dow…

@slipher slipher opened an issue in Unvanquished/updater · April 23, 2024 00:59
Distributing updater with universal zip #117

@Viech suggested an interesting idea in #30 to distribute the updater inside the torrent/universal zip. This would let an installation originally m…

@slipher slipher commented on Unvanquished/updater#63 · April 23, 2024 00:48

OK, naming it updater in the install directory makes sense to me. I have changed my mind about this. The executable basename by itself is what yo…

@slipher slipher commented on Unvanquished/updater#104 · April 23, 2024 00:26

I have a feeling some portion of people will get mad that older DPKs are removed. To implement uninstall, I think I will just have it nuke the whol…

Unvanquished
Unvanquished
Monday, 22 April 2024
@slipher slipher commented on Unvanquished/updater#26 · April 22, 2024 23:52

The updater update case is still broken. In my test the game did not respond to inputs of any kind when launched after an updater update.

@slipher slipher commented on DaemonEngine/Daemon#1094 · April 22, 2024 23:02

I think with a float we should be explicit, != 0

@illwieckz illwieckz commented on DaemonEngine/Daemon#1091 · April 22, 2024 22:56

Should this just be an else rather than an else if case? Since no matter what the condition evaluates to lightStage will be set to -1 if that code…

@illwieckz illwieckz pushed to DaemonEngine/Daemon · April 22, 2024 22:55
2 commits to illwieckz/shader-stage-struct
  • @illwieckz 64f2a61
    tr_shader: fix a bug where stages was used instead of stage (and then…
  • @illwieckz bc3d18e
    renderer: use default value from shader_t and shaderStage_t
  • 6 more commits »
@illwieckz illwieckz deleted branch illwieckz/iterators in DaemonEngine/Daemon · April 22, 2024 22:50

Updated Apr 23

@illwieckz illwieckz pushed to DaemonEngine/Daemon · April 22, 2024 22:50
illwieckz/iterators is now 0000000
@illwieckz illwieckz pushed to DaemonEngine/Daemon · April 22, 2024 22:50
1 commit to master
@illwieckz illwieckz merged DaemonEngine/Daemon#1092 · April 22, 2024 22:50
gl_shader: use iterator #1092

Just a minor code rewrite.

+4 -14
@illwieckz illwieckz deleted branch illwieckz/legacy-dynamic-lighting in DaemonEngine/Daemon · April 22, 2024 22:49

Updated Apr 23

@illwieckz illwieckz pushed to DaemonEngine/Daemon · April 22, 2024 22:49
illwieckz/legacy-dynamic-lighting is now 0000000
@illwieckz illwieckz pushed to DaemonEngine/Daemon · April 22, 2024 22:49
2 commits to master
  • @illwieckz a793a65
    renderer: disable attenuation stages when legacy dynamic renderer isn…
  • @illwieckz 7fe2e83
    renderer: set white colormap for lightmap stage at shader loading time
  • 3 more commits »
@illwieckz illwieckz merged DaemonEngine/Daemon#1093 · April 22, 2024 22:49
Make the legacy dynamic light renderer work again #1093

Something is wrong as the light is too dim, but it works. About the wrongness, here with both map dynamic light, and weapon projectile dynamic light:

+48 -14
@illwieckz illwieckz pushed to DaemonEngine/Daemon · April 22, 2024 22:20
1 commit to illwieckz/legacy-dynamic-lighting
  • @illwieckz 60a3606
    renderer: disable attenuation stages when legacy dynamic renderer isn…
@illwieckz illwieckz commented on DaemonEngine/Daemon#1094 · April 22, 2024 22:14

Used std::array and ResetStruct. 👍️

@illwieckz illwieckz commented on DaemonEngine/Daemon#1094 · April 22, 2024 22:13

Right, the only valid values are 1 and -1 so we can only test one. Done.

@illwieckz illwieckz pushed to DaemonEngine/Daemon · April 22, 2024 22:12
2 commits to illwieckz/shader-stage-struct
  • @illwieckz 7c69927
    tr_shader: fix a bug where stages was used instead of stage (and then…
  • @illwieckz a7f61f0
    renderer: use default value from shader_t and shaderStage_t
@illwieckz illwieckz pushed to DaemonEngine/Daemon · April 22, 2024 22:07
2 commits to illwieckz/shader-stage-struct
  • @illwieckz 01f12c3
    tr_shader: fix a bug where stages was used instead of stage (and then…
  • @illwieckz 1f81492
    renderer: use default value from shader_t and shaderStage_t
@illwieckz illwieckz pushed to DaemonEngine/Daemon · April 22, 2024 22:04
2 commits to illwieckz/shader-stage-struct
  • @illwieckz 2479b68
    tr_shader: fix a bug where stages was used instead of stage (and then…
  • @illwieckz cc4cb80
    renderer: use default value from shader_t and shaderStage_t
@illwieckz illwieckz commented on DaemonEngine/Daemon#1094 · April 22, 2024 22:02

Excellent, this revealed a bug (some other part of the code was using stages instead of stage, and then always stage[0]: tr_shader.cpp:3231:25: err…

@illwieckz illwieckz commented on DaemonEngine/Daemon#1094 · April 22, 2024 21:46

The same is already true with another shader keyword allowing to modify the normals with some expression.

@illwieckz illwieckz commented on DaemonEngine/Daemon#1094 · April 22, 2024 21:45

Well, a diffuse map stage will use a flat normal map fallback if there is no normal map, so an explicit normal scale without normal map would apply…

@illwieckz illwieckz commented on DaemonEngine/Daemon#1094 · April 22, 2024 21:37
@slipher slipher commented on DaemonEngine/Daemon#1094 · April 22, 2024 21:07

I notice the new code produces a different result for normalScale in the case of a goofy shader that has normalScale but does not have a normal map…

@slipher slipher commented on DaemonEngine/Daemon#1094 · April 22, 2024 20:59

How about just comparing the x component to 0?

@slipher slipher commented on DaemonEngine/Daemon#1094 · April 22, 2024 20:56

Better to remove comments that just reproduce the function name verbatim

@slipher slipher commented on DaemonEngine/Daemon#1094 · April 22, 2024 20:55
@slipher slipher commented on DaemonEngine/Daemon#1094 · April 22, 2024 20:54

Use a for-each loop. Alternatively you could change it to std::array<shaderStage_t, 16> and ResetStruct the whole thing without a loop.

@slipher slipher commented on DaemonEngine/Daemon#1094 · April 22, 2024 20:53

Maybe these are big enough that ResetStruct should be used

@slipher slipher commented on DaemonEngine/Daemon#1094 · April 22, 2024 20:51

ASSERT_UNREACHABLE should only be used in special cases where you are forced to write out the useless code path for some reason, e.g. a default swi…

@illwieckz illwieckz opened DaemonEngine/Daemon#1094 · April 22, 2024 20:31
renderer: use default value from shader_t and shaderStage_t #1094

Use default value from shader_t and shaderStage_t. The clearing of the global shader may be a bit slower, but being able to rely on default values …

+69 -93
@illwieckz illwieckz pushed to DaemonEngine/Daemon · April 22, 2024 20:29
2 commits to illwieckz/shader-stage-struct
@illwieckz illwieckz pushed to DaemonEngine/Daemon · April 22, 2024 15:48
2 commits to illwieckz/legacy-dynamic-lighting
  • @illwieckz 107ae30
    renderer: disable attenuation stages when legacy dynamic renderer isn…
  • @illwieckz c843fd8
    renderer: set white colormap for lightmap stage at shader loading time
@illwieckz illwieckz commented on DaemonEngine/Daemon#1093 · April 22, 2024 15:45

I've set the image in tr_shader.cpp. Now making a helper function for a if would probably be overkill. It's also possible that if is just to skip u…

@illwieckz illwieckz pushed to DaemonEngine/Daemon · April 22, 2024 14:16
1 commit to illwieckz/legacy-dynamic-lighting
  • @illwieckz 949ddcc
    renderer: set white colormap for lightmap stage at shader loading time
@illwieckz illwieckz commented on DaemonEngine/Daemon#1093 · April 22, 2024 12:33

Right, it can be a helper function. We may even do pStage->bundle[ TB_DIFFUSEMAP ].image[ 0 ] = tr.whiteImage in tr_shader.cpp at shader processing…

@DolceTriade DolceTriade commented on Unvanquished/unvanquished-infrastructure#39 · April 22, 2024 06:41

I don't think the download counter really matters that much.

@DolceTriade DolceTriade commented on DaemonEngine/Daemon#1093 · April 22, 2024 06:39

Should this be a helper function? Sounds like this pattern might need to be repeated for other types of situations?

@slipher slipher commented on Unvanquished/updater#110 · April 22, 2024 06:39

This feature is too niche to be worth implementing with our limited resources. Universal zips should suffice for people interested in old versions.

@slipher slipher closed an issue in Unvanquished/updater · April 22, 2024 06:38
Allow to install older versions in a "safe" place #110

The problem this feature would solve is that testing if a change is a regression is not easy at all: have to know where the older releases are (if…

3 comments
@slipher slipher commented on Unvanquished/updater#74 · April 22, 2024 06:35

Let's abandon this idea since Windows is the only platform where it's both technically possible and has significant benefits, and due to the UPX an…

@slipher slipher closed an issue in Unvanquished/updater · April 22, 2024 06:35
Self-compressed binaries? #74

@slipher proposed we may ship bare binaries instead of shipping them within .zip files. What if we use a self-compressed format like UPX? I made so…

11 comments
@slipher slipher opened Unvanquished/updater#116 · April 22, 2024 06:31
UI fixes #116

Fix window stuck on top of everything else during self-update Wider custom command line text field Fix the possibility relaunching twice on Window…

+27 -2
@slipher slipher merged Unvanquished/updater#115 · April 22, 2024 03:51
Fix parsing HTML entities in blog title #115

The title of a recent news post was displayed as "Looking for an OpenGL and C++ developer (let’s do portals!)"

+1 -0
@slipher slipher pushed to Unvanquished/updater · April 22, 2024 03:51
1 commit to master
  • @slipher df51333
    Fix parsing HTML entities in blog title
Daemon Engine
Daemon Engine
Sunday, 21 April 2024
@slipher slipher commented on DaemonEngine/Daemon#1090 · April 21, 2024 20:29

I was wrong to say the generator is NMake. Nmake is used for the NaCl secondary build when part of a Visual Studio build, but we don't test that on…

@illwieckz illwieckz pushed to DaemonEngine/Daemon · April 21, 2024 19:53
2 commits to illwieckz/legacy-dynamic-lighting
  • @illwieckz 76bf4f8
    renderer: re-enable the legacy dynamic light renderer
  • @illwieckz 0a09a0c
    renderer: set whiteImage as lightmap colormap in Render_forwardLighti…
@illwieckz illwieckz pushed to DaemonEngine/Daemon · April 21, 2024 19:10
2 commits to illwieckz/ci-parallel-build
  • @illwieckz 5161deb
    ci/azure: unify the way to set parallel build, report the core count,…
  • @illwieckz d7892a5
    ci/appveyor: build in parallel, report the core count, overload cores
@illwieckz illwieckz commented on DaemonEngine/Daemon#1090 · April 21, 2024 19:07

Whatever what is parallelized, I got this here: dummyapp.vcxproj -> C:\projects\daemon\build\Release\dummyapp.exe files.cpp huffman.cpp msg.cpp ne…

@illwieckz illwieckz pushed to DaemonEngine/Daemon · April 21, 2024 19:04
2 commits to illwieckz/ci-parallel-build
  • @illwieckz 7783044
    ci/azure: unify the way to set parallel build, report the core count,…
  • @illwieckz a84c371
    ci/appveyor: build in parallel, report the core count, overload cores
@slipher slipher commented on DaemonEngine/Daemon#1090 · April 21, 2024 19:00

If the CMake parallelism turns out to do anything It looks like it helps at doing cmake things in parallel like generating the .h from glsl file…

@illwieckz illwieckz commented on DaemonEngine/Daemon#1090 · April 21, 2024 18:56

We already insert /MP in MSVC builds because it is needed to make Visual Studio build in parallel so I wouldn't expect adding it again to change a…

@slipher slipher commented on DaemonEngine/Daemon#1090 · April 21, 2024 18:55

NMake apparently doesn't have a -j equivalent so that part will probably be a no-op from CMake as well. https://stackoverflow.com/questions/601970/…

@slipher slipher commented on DaemonEngine/Daemon#1090 · April 21, 2024 18:52

If the CMake parallelism turns out to do anything, it would be nicer to use the --parallel option of cmake --build rather than an environment. We a…

@illwieckz illwieckz opened DaemonEngine/Daemon#1093 · April 21, 2024 18:47
Make the legacy dynamic light renderer work again #1093

Something is wrong as the light is too dim, but it works. About the wrongess, here with both map dynamic light, and weapon projectile dynamic light:

+48 -9
@illwieckz illwieckz pushed to DaemonEngine/Daemon · April 21, 2024 18:42
2 commits to illwieckz/legacy-dynamic-lighting
@illwieckz illwieckz commented on DaemonEngine/Daemon#1090 · April 21, 2024 16:58

The idea of overloading a bit the CPU cores is that it usually allows to save some time because both the compiler and the build system (CMake, make…

@illwieckz illwieckz opened DaemonEngine/Daemon#1092 · April 21, 2024 16:55
gl_shader: use iterator #1092

Just a minor code rewrite.

+4 -14
@illwieckz illwieckz pushed to DaemonEngine/Daemon · April 21, 2024 16:54
2 commits to illwieckz/iterators
@illwieckz illwieckz created a branch in DaemonEngine/Daemon · April 21, 2024 16:54
@illwieckz illwieckz opened DaemonEngine/Daemon#1091 · April 21, 2024 16:44
tr_shader: forget lightmap if not collapsed, so it can be rediscovered #1091

Prevent this kind of error when we detected a lightmap but we cannot collapse it with the next colormap: Warn: more than one lightmap stage in shad…

+4 -0
@illwieckz illwieckz pushed to DaemonEngine/Daemon · April 21, 2024 16:43
2 commits to illwieckz/forget-lightmap
@illwieckz illwieckz commented on DaemonEngine/Daemon#1090 · April 21, 2024 15:48

I moved out of the appveyor script the commenst, to avoid those errors: The system cannot find the file specified. Both the standard REM remark (c…

@illwieckz illwieckz pushed to DaemonEngine/Daemon · April 21, 2024 15:38
2 commits to illwieckz/dpcvars
  • @illwieckz eafd3c4
    common: NUKE the confusing and now unused *cvar syntax alternative fo…
  • @illwieckz 8041693
    engine: use explicit cvar.Get() wording for reading cvar value
@illwieckz illwieckz commented on DaemonEngine/Daemon#1066 · April 21, 2024 15:30

I added a commit to NUKE the confusing *cvar syntax, it was used nowhere else.

@illwieckz illwieckz pushed to DaemonEngine/Daemon · April 21, 2024 15:30
1 commit to illwieckz/dpcvars
  • @illwieckz 904afab
    common: NUKE the confusing and now unused *cvar syntax alternative fo…
@illwieckz illwieckz pushed to DaemonEngine/Daemon · April 21, 2024 15:29
2 commits to illwieckz/dpcvars
@illwieckz illwieckz pushed to DaemonEngine/Daemon · April 21, 2024 15:25
2 commits to illwieckz/ci-parallel-build
  • @illwieckz ea18aea
    ci/azure: unify the way to set parallel build, report the core count,…
  • @illwieckz 2e02481
    ci/appveyor: build in parallel, report the core count, overload cores
  • 2 more commits »
@illwieckz illwieckz pushed to DaemonEngine/Daemon · April 21, 2024 15:11
2 commits to illwieckz/ci-parallel-build
  • @illwieckz 81ecf06
    ci/azure: unify the way to set parallel build, be more verbose, overl…
  • @illwieckz 130e28d
    ci/appveyor: build in parallel, print the copre count, overload cores
  • 1 more commit »
@illwieckz illwieckz commented on DaemonEngine/Daemon#1090 · April 21, 2024 14:56

All I save with Appveyor/MSVC is 30s… 😐️ We basically go from 8m40 to 8m10 for a single build. It's always welcome, but I as hoping more.